IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)

Marten Seemann <notifications@github.com> Tue, 18 August 2020 03:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AA353A16D8 for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 20:23:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 68eSsv9MQISw for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 20:23:22 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E544E3A16C9 for <quic-issues@ietf.org>; Mon, 17 Aug 2020 20:23:21 -0700 (PDT)
Received: from github-lowworker-1dbcc59.ash1-iad.github.net (github-lowworker-1dbcc59.ash1-iad.github.net [10.56.105.54]) by smtp.github.com (Postfix) with ESMTP id 0846A560599 for <quic-issues@ietf.org>; Mon, 17 Aug 2020 20:23:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597721001; bh=qgcy8zwVnM6AE1xct9G9A8VJO4zettZGFo59FdJQc2A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TWXMGn/Tc6HiWYQNKVKwz5jlOXVM9cCHmr0QoBv4vY4ZV89+mPpuHgCt0rR5/Aznc SZm/JiBbaEHA9uGfxrlm1fEbAIYegCFYpBd7KLgRGKeSOMuF4pxquhFIfEJJ4JC1w+ 2T9Q7b/bDKlsn+WixyLug1osqOrBtMvEWEVqIeVM=
Date: Mon, 17 Aug 2020 20:23:20 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK73UELJAPTNJ3MSX655I4VKREVBNHHCREMQGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4010/review/468964519@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4010@github.com>
References: <quicwg/base-drafts/pull/4010@github.com>
Subject: Re: [quicwg/base-drafts] Persistent congestion pseudocode to match text (#4010)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3b49a8eb657_431b1964196396"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h2eQ7PlJnq1aokk_K7opMsSLErQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 03:23:23 -0000

@marten-seemann requested changes on this pull request.



> @@ -1514,6 +1517,7 @@ variables as follows:
    bytes_in_flight = 0
    congestion_recovery_start_time = 0
    ssthresh = infinite
+   first_rtt_sample = never

We use 0 to initialize the other time variables.

>       pto = smoothed_rtt + max(4 * rttvar, kGranularity) +
        max_ack_delay
-     congestion_period = pto * kPersistentCongestionThreshold
+     pc_period = pto * kPersistentCongestionThreshold
+
+     // Only look for persistent congestion if the period
+     // starts after getting the first RTT sample.
+     assert(first_rtt_sample is not never)
+     if (largest_lost.time_sent - pc_period > first_rtt_sample):

```suggestion
     if (smallest_lost.time_sent - pc_period > first_rtt_sample):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4010#pullrequestreview-468964519

v2.23.0 | Report a Bug | By Email