Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)

Nick Harper <notifications@github.com> Thu, 17 October 2019 18:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5572B120B91 for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 11:08:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ypTXkSFVFS0a for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 11:08:30 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 60DE81208A4 for <quic-issues@ietf.org>; Thu, 17 Oct 2019 11:08:30 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id BF2166E04A1 for <quic-issues@ietf.org>; Thu, 17 Oct 2019 11:08:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571335709; bh=qNkfFdynLuSWN198s/w49BaAVSm7ZWtB2Gq+LWnSR4c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pMwb28k62QW7dq394T7JqRpqspw1npshQVtt8nYmKvFkfwKYMZl0+YSN/z+KAkQ3/ pITgzzkqkgjGcWKx3+Z1HUH6feCRum+ebSk2+WZXX8pQg0OhpEx6SKlu7EcFNqzq02 66GJoW8u2nxQwPq2HcH4YCQDtZvMW2vLUk+U/pB0=
Date: Thu, 17 Oct 2019 11:08:29 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4VMKJSDVG4YAWJPSF3WXXK3EVBNHHB4UIFQY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3113/review/303446773@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3113@github.com>
References: <quicwg/base-drafts/pull/3113@github.com>
Subject: Re: [quicwg/base-drafts] Clarify that clients don't need to remember unknown SETTINGS (#3113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da8ae1d8b4b0_61a3fb0fb2cd968290c6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h32hTiRECxObqLS65iJ0grl_SkU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Oct 2019 18:08:32 -0000

nharper commented on this pull request.



> @@ -1229,10 +1229,13 @@ A server MAY accept 0-RTT and subsequently provide different settings in its
 SETTINGS frame. If 0-RTT data is accepted by the server, its SETTINGS frame MUST
 NOT reduce any limits or alter any values that might be violated by the client
 with its 0-RTT data.  The server MUST include all settings which differ from
-their default values.  If a server accepts 0-RTT, but then sends a SETTINGS
-frame which reduces a setting the client understands or omits a value that was
-previously specified to have a non-default value, this MUST be treated as a
-connection error of type HTTP_SETTINGS_ERROR.
+their default values.  If a server accepts 0-RTT but then sends a SETTINGS

I think that's implied - if a reserved setting was specified, then it was specified to have a non-default value (since there is no default value).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3113#discussion_r336151299