Re: [quicwg/base-drafts] Use CONNECTION_CLOSE rather than CRYPTO_CLOSE (#1477)

[Mike Bishop <[e-mail]>]

MikeBishop approved this pull request.

Yes please.

> @@ -602,10 +602,16 @@ HelloRetryRequest is still used for incorrect key shares.
 
 ## TLS Errors
 
-If TLS experiences an error, it MUST generate an appropriate alert
-as defined in {{TLS13}}; Section 6) and then provide it to QUIC,
-which sends the alert in a CRYPTO_CLOSE frame. All such alerts are
-"fatal" (see {{TLS13}}, Section 6.2.
+If TLS experiences an error, it generates an appropriate alert as defined in
+Section 6 of {{TLS13}}.
+
+A TLS alert is turned into a QUIC connection error by converting the one-octet
+alert description into a QUIC error code.  The alert description is added to
+0x200 to produce a QUIC error code from the range reserved for CRYPTO_ERROR.
+The resulting value is sent in a QUIC CONNECTION_CLOSE frame.
+
+The alert level of all TLS alerts is "fatal", a TLS stack MUST NOT generate

Comma splice.  Separate sentences or `;`.

> @@ -1032,7 +1032,6 @@ explained in more detail as they are referenced later in the document.
 | 0x0f        | PATH_RESPONSE     | {{frame-path-response}}     |
 | 0x10 - 0x17 | STREAM            | {{frame-stream}}            |
 | 0x18        | CRYPTO_HS         | {{frame-crypto}}            |
-| 0x19        | CRYPTO_CLOSE      | {{frame-crypto-close}}      |
 | 0x20        | NEW_TOKEN         | {{frame-new-token}}         |

No objection, but also seems unnecessary.  Leave 0x19 for the next frame to be defined, and if there are gaps in the space we'll defrag before we ship.

> @@ -2200,10 +2199,9 @@ before the packet is received.
 
 ### Immediate Close
 
-An endpoint sends a closing frame, (CONNECTION_CLOSE, CRYPTO_CLOSE or
-APPLICATION_CLOSE) to terminate the connection immediately.  Any
-closing frame causes all streams to immediately become closed; open
-streams can be assumed to be implicitly reset.
+An endpoint sends a closing frame, (CONNECTION_CLOSE or APPLICATION_CLOSE) to

Unnecessary comma

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1477#pullrequestreview-132199013