[quicwg/base-drafts] Transport error codes would be smaller and more consistent as a varint (#2672)

ianswett <notifications@github.com> Tue, 07 May 2019 20:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F976120128 for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 13:24:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.464
X-Spam-Level:
X-Spam-Status: No, score=-6.464 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xbSqjtRAmbVx for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 13:24:48 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B10D71201D6 for <quic-issues@ietf.org>; Tue, 7 May 2019 13:24:47 -0700 (PDT)
Date: Tue, 07 May 2019 13:24:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557260686; bh=r8hwLqPEERJyaYs/ehkElWd7Dxqj5ux+3n2qHZtwjbc=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=It3LW6qoJVYnUXa4A6TuqoTz1DfuoOJTGJKXeRrom/jEkmKM8jw3V/IbP+APdGcVZ Bfyk+O3K2fv7QOarYzp/6HzCBqK9+uOITShYSlsTSx3GEIu5ApHaJtznzSbQ2Tde/o j7kwIZM9LGUcuAoDYnAPOYB71Fc3xFnnJjTn15Vw=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3UU2QA4QCYSRKX2N5234OA5EVBNHHBUT5QOM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2672@github.com>
Subject: [quicwg/base-drafts] Transport error codes would be smaller and more consistent as a varint (#2672)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd1e98e5bb9e_53033f8ebfacd96452764"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h8GB04cuQqnSZ_hKVi9g3nQgIwU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 May 2019 20:24:49 -0000

Currently there are three spots in the QUIC transport spec which used fixed length(16-bit) integers:
* Connection Close error code
* Application Protocol Error Code in Reset Stream
* Application Error Code in Stop Sending

This typically makes reset stream and stop sending frames 1 byte larger than they need to be, which could be slightly annoying if one is churning through a huge number of streams.

It creates some unnecessary oddness in the HTTP/3 spec, where the HTTP_MALFORMED_FRAME(0x01XX) is describing a frame type that's a varint.  Admittedly, there would still be a limit of 2^60 being expressible, but it's easy to avoid that.

I think all 3 fields would be better as a varint, given our recent decisions to make HTTP/3 all varints.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2672