Re: [quicwg/base-drafts] Remove packet number re-randomization requirement (#824)
Martin Thomson <notifications@github.com> Tue, 10 October 2017 23:42 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 59C561344B8 for <quic-issues@ietfa.amsl.com>; Tue, 10 Oct 2017 16:42:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.615
X-Spam-Level:
X-Spam-Status: No, score=-5.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3J_9_TGh_MLq for <quic-issues@ietfa.amsl.com>; Tue, 10 Oct 2017 16:42:02 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext8.iad.github.net [192.30.252.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF2851332DA for <quic-issues@ietf.org>; Tue, 10 Oct 2017 16:42:01 -0700 (PDT)
Date: Tue, 10 Oct 2017 16:42:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1507678921; bh=+g1go4xov9LSUhYtYCyaoiZ+4ewVjrJIspJgERJqKCY=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0pRq9uEQWFBtVYug4EHyucD+OgU5VmgWX1XEQNOco8jMNuFlySoGeimHThpStmN5H CFrQmM55QTkZZvbtYVwPs8QHpIn0CQHL8BZCX3GbSyCxjQcGcUNxZQhok5KnPfiTT/ FkYwY+FQ1fpeCdCro+v+qrYnPXavASzxjloqenU0=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdea3b0d332a29b311544a68f894e6a317b7a99a192cf0000000115f51cc992a169ce0fa5cd56@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/824/review/68458007@github.com>
In-Reply-To: <quicwg/base-drafts/pull/824@github.com>
References: <quicwg/base-drafts/pull/824@github.com>
Subject: Re: [quicwg/base-drafts] Remove packet number re-randomization requirement (#824)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59dd5ac91628a_7fcb3fa19d18af285121d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hBTZlDNGstTSqzmwrcLGg9j7hNA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2017 23:42:03 -0000
martinthomson commented on this pull request. > @@ -907,9 +896,9 @@ When the client receives a Version Negotiation packet from the server, it should select an acceptable protocol version. If the server lists an acceptable version, the client selects that version and reattempts to create a connection using that version. Though the contents of a packet might not change in -response to version negotiation, a client MUST increase the packet number it -uses on every packet it sends. Packets MUST continue to use long headers and -MUST include the new negotiated protocol version. +response to version negotiation, a client MUST increase the packet number by one Right, though you won't be migrating during version negotiation, so your fix works. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/824#discussion_r143880909
- [quicwg/base-drafts] Remove packet number re-rand… Martin Thomson
- Re: [quicwg/base-drafts] Remove packet number re-… Mike Bishop
- Re: [quicwg/base-drafts] Remove packet number re-… janaiyengar
- Re: [quicwg/base-drafts] Remove packet number re-… Martin Thomson
- Re: [quicwg/base-drafts] Remove packet number re-… Martin Thomson
- Re: [quicwg/base-drafts] Remove packet number re-… janaiyengar
- Re: [quicwg/base-drafts] Remove packet number re-… janaiyengar
- Re: [quicwg/base-drafts] Remove packet number re-… Martin Thomson
- Re: [quicwg/base-drafts] Remove packet number re-… Martin Thomson
- Re: [quicwg/base-drafts] Remove packet number re-… Martin Thomson