Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)

ianswett <notifications@github.com> Mon, 19 March 2018 10:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8C240126E64 for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 03:48:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fadKC1F20ihM for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 03:48:44 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 030BE126DEE for <quic-issues@ietf.org>; Mon, 19 Mar 2018 03:48:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=TxAgXxom4OMh3cKcrdsz4ETbIso=; b=w8BuIquuI8sGQHkJ ahB5CM4ial9xf3uj/PUhhJdYq+xZMi7XChoa0CTaTOHvYSMqrzzQQB/PFpI6oQpf ZsSqlauamDq4VgQanbv1uBKSEK4x5GqmNOgUoMqPdYek/K3gMn3UOCDsz+kMGKw9 XhlV1J4PSJwNFWYMaKPsMYIA1Xg=
Received: by filter0070p1iad2.sendgrid.net with SMTP id filter0070p1iad2-20875-5AAF958A-23 2018-03-19 10:48:42.900247321 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0007p1iad1.sendgrid.net (SG) with ESMTP id yC43OF9RREiRt1nBBtTAvA for <quic-issues@ietf.org>; Mon, 19 Mar 2018 10:48:42.731 +0000 (UTC)
Date: Mon, 19 Mar 2018 10:48:43 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6850ed60f9bf932eb73acbeac2cf4379d6fcb89992cf0000000116c7578a92a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104911464@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aaf958a98ded_f432b0bfb3c6ec86001b2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0Xms+65F6HRDIQMtS6f1ssdfQMwF7hddwVqV 20YlnFdtbeJbgPG+5Y0TkgesZpPZQNf8yRHGUhokcNjflTU+vDwX3Y4aDuzDGwuBFdvgfIVw70UZLu IQzRYer32GOtDwytZkt2O31fjPw5SerBAjRIqoy6gBRGxfAhNZR/3EEsxv4a7YI9HBSNpGebVWAGXT E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hBWTJw4uqLeSGQGxBHhsG3io5WA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 10:48:46 -0000

ianswett commented on this pull request.



>  
 To limit ACK blocks to those that have not yet been received by the sender, the
 receiver SHOULD track which ACK frames have been acknowledged by its peer.  Once
 an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
 acknowledged again.
 
-A receiver that is only sending ACK frames will not receive acknowledgments for
-its packets.  Sending an occasional MAX_DATA or MAX_STREAM_DATA frame as data is
-received will ensure that acknowledgements are generated by a peer.  Otherwise,
-an endpoint MAY send a PING frame once per RTT to solicit an acknowledgment.
+Because ACK-only packets are not acknowledged, a receiver that is only
+sending ACK frames will only receive acknowledgements for its packets
+if the sender piggybacks them on other packets. In order to enable
+this, senders SHOULD prioritize sending ACKs along with their data.

I think prioritize is a loaded word, maybe "senders SHOULD bundle ACKs with non-ACK frames when possible."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1231#discussion_r175392605