IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)

Marten Seemann <notifications@github.com> Tue, 17 July 2018 15:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E860130EAE for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 08:25:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6gtx-qkTljOY for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 08:25:04 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 018B2130F46 for <quic-issues@ietf.org>; Tue, 17 Jul 2018 08:24:59 -0700 (PDT)
Date: Tue, 17 Jul 2018 08:24:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531841098; bh=I4iOD7PsE/1DLTyhojpJUcUmBuWS60hPEi27FmDMYaU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=t4mBn057GU87enZYd567BIuPI+QUd4qm8upQoWT+TnJzPyj8zkq0l2lMWCdPOrenm b8md1hFQBPSYffPmdxIKaY3io8VrrdbEt+MUwoDzAa7Om58XdEZrGCO0DKEdDP98IM 5fu1QVcbTdwRqVhkTK4cTYgpx3XMlHdMGOwBvHug=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab58afa9fadea91a8fd3ba8bc68f0f54adbe2a3fe592cf000000011765cc4a92a169ce1461f5c3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1574/review/137883999@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1574@github.com>
References: <quicwg/base-drafts/pull/1574@github.com>
Subject: Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4e0a4a3398a_5d073fee32538f801052c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hBrDHZ7MSPsim6cZ6iiToWeHXcw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2018 15:25:27 -0000

marten-seemann commented on this pull request.



> @@ -206,6 +206,17 @@ Min RTT is the minimum RTT measured over the connection, prior to adjusting by
 ack delay.  Ignoring ack delay for min RTT prevents intentional or unintentional
 underestimation of min RTT, which in turn prevents underestimating smoothed RTT.
 
+### Maximum Ack Delay
+
+QUIC is able to explicitly model delay at the receiver via the ack delay
+field in the ACK frame.  Therefore, QUIC diverges from TCP by calculating a
+MaxAckDelay dynamically, instead of assuming a constant delayed ack timeout
+for all connections.
+
+MaxAckDelay is the maximum ack delay supplied in an incoming ACK frame.

In all incoming ACK frames?

> @@ -206,6 +206,17 @@ Min RTT is the minimum RTT measured over the connection, prior to adjusting by
 ack delay.  Ignoring ack delay for min RTT prevents intentional or unintentional
 underestimation of min RTT, which in turn prevents underestimating smoothed RTT.
 
+### Maximum Ack Delay
+
+QUIC is able to explicitly model delay at the receiver via the ack delay
+field in the ACK frame.  Therefore, QUIC diverges from TCP by calculating a
+MaxAckDelay dynamically, instead of assuming a constant delayed ack timeout
+for all connections.
+
+MaxAckDelay is the maximum ack delay supplied in an incoming ACK frame.
+MaxAckDelay excludes ack delays that aren't included in an RTT sample because

Should we say "that don't have a larger Largest Acknowledged"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1574#pullrequestreview-137883999

v2.23.0 | Report a Bug | By Email