IETF Logo Mail Archive

Re: [quicwg/base-drafts] Example of ChaCha20-Poly1305 (#3712)

Marten Seemann <notifications@github.com> Tue, 02 June 2020 08:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8B233A0A3B for <quic-issues@ietfa.amsl.com>; Tue, 2 Jun 2020 01:41:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.982
X-Spam-Level:
X-Spam-Status: No, score=-0.982 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, PDS_BTC_ID=0.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s4vQXzK8m14U for <quic-issues@ietfa.amsl.com>; Tue, 2 Jun 2020 01:41:00 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 960953A0A3A for <quic-issues@ietf.org>; Tue, 2 Jun 2020 01:41:00 -0700 (PDT)
Received: from github-lowworker-f1f7af9.ash1-iad.github.net (github-lowworker-f1f7af9.ash1-iad.github.net [10.56.111.13]) by smtp.github.com (Postfix) with ESMTP id 94E0A2C11D1 for <quic-issues@ietf.org>; Tue, 2 Jun 2020 01:40:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1591087259; bh=Nxc//wxBG2mh52czqaibEf65P+RvEH+n1Bt3Xehwktw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ep3WBEK/9cRvwEjxeHWa0f3LHgyjdm/8JfHZws505sXAWSJSSRD8Ph6W/pFCqNkrT aWGck8/AOtfHQmWFLobmEWWH21SougE0JdjQUEfJZ9VsIpzGf2Y50S+Hu7AWVAwGZ2 1kwHOnLdAdGOVyZf6WSd5wn8ovWrxMp8vlKHhI90=
Date: Tue, 02 Jun 2020 01:40:59 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZLYAKRPRKXXJHQSDN44HYZXEVBNHHCK7K3HI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3712/review/422463731@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3712@github.com>
References: <quicwg/base-drafts/pull/3712@github.com>
Subject: Re: [quicwg/base-drafts] Example of ChaCha20-Poly1305 (#3712)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ed6109b84dfb_11153f9cb0ecd95c404689"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hCeBl-c6jx2fYU_gGzhZJzW82-4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jun 2020 08:41:02 -0000

@marten-seemann commented on this pull request.



> +      73573685608597d0efcb076b0ab7a7a4
+
+ku  = HKDF-Expand-Label(server_initial_secret, "quic ku", _, 32)
+    = 1223504755036d556342ee9361d25342
+      1a826c9ecdf3c7148684b36b714881f9
+~~~
+
+The following shows the steps involved in protecting a minimal packet with an
+empty Destination Connection ID. This packet contains a single HANDSHAKE_DONE
+frame (that is, a payload of just 0x1e) and has a packet number of 0. In this
+example, a packet number of length 3 is used to avoid having to pad the payload
+of the packet; PADDING frames would be needed if the packet number is encoded
+on fewer octets.
+
+~~~
+pn                 = 0

I'd prefer to use a non-zero value here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3712#pullrequestreview-422463731

v2.23.0 | Report a Bug | By Email