IETF Logo Mail Archive

Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)

Junho Choi <notifications@github.com> Mon, 27 July 2020 18:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 41AD73A1AE4 for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 11:11:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jtOxTzUTD81M for <quic-issues@ietfa.amsl.com>; Mon, 27 Jul 2020 11:11:16 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B42F3A1041 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 11:11:16 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id 4E817340EA7 for <quic-issues@ietf.org>; Mon, 27 Jul 2020 11:11:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595873475; bh=e5JffPXk4uJxejw8rIb5ZQIDBPNGH9VO/Cv6u6gnXwA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zybfW4pPAL5Myipi3sBp7Ux15idaXt4W8QkHZMKMbNYEr6Nd3mrtgiond/fQVZALY gI3Prah9712rNyouAfgFwoqbl7MN+ywedzn5NqeIQThdfqSMbUI24CPI11y0GkZnDt HSlyKvaLVKCgL8i8qCoqJjk5vnpIcpq8JSCoC2gw=
Date: Mon, 27 Jul 2020 11:11:15 -0700
From: Junho Choi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK43SP7MR5YM5BFNXOV5FL44HEVBNHHCOPRYC4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3917/review/456019318@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3917@github.com>
References: <quicwg/base-drafts/pull/3917@github.com>
Subject: Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1f18c33f284_53903fc560ecd960275617"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: junhochoi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hDrUxTqpTOB65LeKQqrjrJhOB9k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2020 18:11:18 -0000

@junhochoi commented on this pull request.



> @@ -1560,6 +1566,7 @@ window.
      if (!InCongestionRecovery(sent_time)):
        congestion_recovery_start_time = now()
        congestion_window *= kLossReductionFactor
+       bytes_acked *= kLossReductionFactor

Just thinking again... this is when a recovery episode starts and we enter congestion avoidance by ssthresh=cwnd. And bytes_acked is only used in congestion avoidance and doing nothing during slow start.

I think we simply clear bytes_acked to 0 as @ianswett said because it's a new start of congestion avoidance, or no need to touch bytes_acked because even if there is a previous leftover bytes_acked, it will not impact much.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3917#discussion_r461076097

v2.30.2 | Report a Bug | By Email | System Status