Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)

Igor Lubashev <notifications@github.com> Thu, 13 December 2018 21:53 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20613130DEB for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 13:53:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aNVb03HoSqFR for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 13:52:59 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D92F130EA7 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 13:52:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ZJP6/+qdcUm8HmDGDRJSc9ydVAs=; b=ozA84T0zNQ0qoQN3 qGhYSTHDkJLjab4ysmiZBs/WH79nEHf7q1xZuExlAB0CioK3udsg+6K+GzR2cjKn qBL57x74HvUJpiw3COFmYvSasGY+K5dw06/11AhU0WWTP2zF5Jl49WHILCRgXzfl Qh6f8czG2O41Tzi4VNGHVe2mfng=
Received: by filter0006p1iad2.sendgrid.net with SMTP id filter0006p1iad2-22393-5C12D4B9-13 2018-12-13 21:52:57.227493532 +0000 UTC m=+253434.166592674
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0027p1iad2.sendgrid.net (SG) with ESMTP id Vw_hscSiSYWFTPC-f1faow for <quic-issues@ietf.org>; Thu, 13 Dec 2018 21:52:57.220 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 385DE440DE8 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 13:52:57 -0800 (PST)
Date: Thu, 13 Dec 2018 21:52:57 +0000
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba76a0caa9cdfb6c5bab2ae48e4fc4158517b3d5292cf00000001182a96b992a169ce174c2f88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2161/c447133989@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2161@github.com>
References: <quicwg/base-drafts/pull/2161@github.com>
Subject: Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12d4b936fa5_14283f9fa7ad45b879911"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0wh7B0GZh1bFuqGpIHm2nKUEKCt+G/xhfSmQ +/6MYHGZgoda+n0+qEdKIEA+Uni8GPQR9/w1bn0Kyl1N2d/sl57P4WKtlFc1+7cnnFcoVVpO2Yy0dS +s8/bp7atXvtGZQFBnHsViTBimMDMKppJA3lH6Ur6uMi7JbSV5BXawSy/qQEDjfG7Xb9dmSH3zqFxF M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hIXtu0AEYBkQgBbxRHehi8brDcw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 21:53:01 -0000

Note: it would be wrong to increase PMTU merely due to a receipt of a validated ICMP PTB message received in response to a PMTU probe.  Only an ACK of a probe can increase PMTU to the probe's size.  But a receipt of such ICMP PTB message can trigger a new PMTU probe of the given size.

All of this is a subject to DPLPMTUD specification.  Hence, I did not include it in this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2161#issuecomment-447133989