Re: [quicwg/base-drafts] Packet matching for zero-length connection IDs (#3321)

Benjamin Saunders <notifications@github.com> Wed, 08 January 2020 02:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E11DC1200EB for <quic-issues@ietfa.amsl.com>; Tue, 7 Jan 2020 18:44:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id deyGdkMfrt8t for <quic-issues@ietfa.amsl.com>; Tue, 7 Jan 2020 18:44:49 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3176B12002E for <quic-issues@ietf.org>; Tue, 7 Jan 2020 18:44:49 -0800 (PST)
Date: Tue, 07 Jan 2020 18:44:48 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1578451488; bh=OJsER6nB64c5jWr5vdAlIWuIBvWUlQQx+/pJZfdqU68=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yK5eafllJ0ImJY8Mg+Xnwld2FU9hdUWuXVvNICwZUT5ERxzsx8cD4ztj3xT8UwHaI OSjiD+LI3rIG5UyIVoCJ8OqkVfYcHq5jxQJppz68MBwrbEK2Q1zACiSu1xJbpy4WOW xn8GsjlschTEiTuCWRjzQO8+S1c8aqatgNQdKxA8=
From: Benjamin Saunders <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK727SJQUUORW7WGWXF4EJ2KBEVBNHHCBDCTE4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3321/review/339621448@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3321@github.com>
References: <quicwg/base-drafts/pull/3321@github.com>
Subject: Re: [quicwg/base-drafts] Packet matching for zero-length connection IDs (#3321)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e15422024d09_6ef3faf9b4cd968116147"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: Ralith
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hPuXNp4BzJJE03NL-s4rh4XHZMQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jan 2020 02:44:51 -0000

Ralith commented on this pull request.



> @@ -1068,9 +1069,12 @@ has a non-zero-length Destination Connection ID corresponding to an existing
 connection, QUIC processes that packet accordingly. Note that more than one
 connection ID can be associated with a connection; see {{connection-id}}.
 
-If the Destination Connection ID is zero length and the packet matches the
-local address and port of a connection where the endpoint used zero-length
-connection IDs, QUIC processes the packet as part of that connection.
+If the Destination Connection ID is zero length and the addressing information
+in the packet matches the addressing information the endpoint uses to identify a
+connection with a zero-length connection ID, QUIC processes the packet as part
+of that connection.  An endpoint can use just destination IP and port or both

Conversely, I find "addressing information" to be vague, and the second sentence is much clearer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3321#discussion_r364043628