Re: [quicwg/base-drafts] ACK retransmission (#63)

martinduke <notifications@github.com> Tue, 06 December 2016 00:37 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AEE52128B38 for <quic-issues@ietfa.amsl.com>; Mon, 5 Dec 2016 16:37:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.915
X-Spam-Level:
X-Spam-Status: No, score=-4.915 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.896, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c4h1snYvw4jl for <quic-issues@ietfa.amsl.com>; Mon, 5 Dec 2016 16:37:27 -0800 (PST)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0917012962B for <quic-issues@ietf.org>; Mon, 5 Dec 2016 16:37:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=z3CJCQmECfAREIQekRCX2woifb4=; b=VV+tQDTztiVyS+pv 4nVpwBxbrXNrpLXFTw+aqYC5lp3AL7iKwerkzs3jJEIT9YeU1SUPoZ2S7j2Qxeox qEvr9AY8fft2goegqqgHg7ohG/ObulhTvvAKV6eKk/m/ty8stl/eExLqgdcLoLdC CUC/4KP3pHIDL5MHrDiUj8HvgKc=
Received: by filter0487p1mdw1.sendgrid.net with SMTP id filter0487p1mdw1-30606-58460845-F 2016-12-06 00:37:25.254527779 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id 3A9GCb_LTnWcLrYx5dtuBg for <quic-issues@ietf.org>; Tue, 06 Dec 2016 00:37:25.164 +0000 (UTC)
Date: Mon, 05 Dec 2016 16:37:25 -0800
From: martinduke <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/63/265024921@github.com>
In-Reply-To: <quicwg/base-drafts/issues/63@github.com>
References: <quicwg/base-drafts/issues/63@github.com>
Subject: Re: [quicwg/base-drafts] ACK retransmission (#63)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5846084512fd2_70d53fa5a4ff91301483ec"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0YvN8ZW5Dzp0ldZRcaz3KtAkiN0EEc3pec1T 7gC/pUoAttfpXut16nYXalYaC7xmd8yu9Bd20bcUCRgT6YoCKDZHfu7VCqdzoLSY3pxKy6/kfsHCWC VyL4W7Tn2R33F+h+JZ7GRnKN5oT1PxSCRff40Fc2+9Vz2ILpVBFXKXrd2ZQTsTaktvWYLPOL0dmrxM g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hQnbshZkMUZLKH6Iz4woS4PxA4U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quicwg/base-drafts <reply+0166e4ab1cd6239742480bba7f4f132a15aa4322dad0552792cf00000001145dca4592a169ce0b80e148@reply.github.com>
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2016 00:37:30 -0000

Ah. OK. My first hack at implementing this did what you describe, then I realized that the alternate approach would save lot of bytes, though with more bookkeeping. I see now that the words are there in Section 6.2 but it would be nice to have a more explicit requirement, e.g. "A receiver SHOULD repeat SACK blocks until those packets are covered by a STOP_WAITING".

To be honest, I think tracking which of my acks have been acked would reduce the control overhead of the protocol without requiring any wire format changes. But this might all be moot if STOP_WAITING dies.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/63#issuecomment-265024921