Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)
ianswett <notifications@github.com> Tue, 11 June 2019 18:35 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B3ECE120186 for <quic-issues@ietfa.amsl.com>; Tue, 11 Jun 2019 11:35:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d9UZTuPRiowB for <quic-issues@ietfa.amsl.com>; Tue, 11 Jun 2019 11:35:17 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC3E6120020 for <quic-issues@ietf.org>; Tue, 11 Jun 2019 11:35:16 -0700 (PDT)
Date: Tue, 11 Jun 2019 11:35:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560278115; bh=/4RibX29P9t3hanlUlJ5yaFvMuOH8+LHEOUVz1a/jxM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ae8T3a5YglpsdyP+ibeJvXJCCo4KSHJ7y5VItwzTeOnClyDW4q4kw6x+GQux1MUxR 74kzk9qWPNA6oIymEjI3c9+mYCA64csWLLc+6b4n2NMpvMNbUCsx88KFf/2kfN5Z3P C8MAVZ+eUea65twjC1M6BZGRFs02AAQ/nA3Kz7j0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2NOUALWTAXD74CGLN3BUTOHEVBNHHBV45H2U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2769/review/248359629@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2769@github.com>
References: <quicwg/base-drafts/pull/2769@github.com>
Subject: Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cfff46380596_1c733f96a4ecd96411303a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hRVnEEGaKKPLLRCBL9VJRw073ww>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jun 2019 18:35:19 -0000
ianswett commented on this pull request. Some small suggestions, but this LG overall. > @@ -5018,6 +5034,31 @@ sequence number, or if a sequence number is used for different connection IDs, the endpoint MAY treat that receipt as a connection error of type PROTOCOL_VIOLATION. +The Retire Prior To field is a requirement for the peer to retire all connection +IDs with a sequence number less than the specified value. This includes the +initial and preferred_address transport parameter connection IDs. The peer +SHOULD immediately retire all the connection IDs. + +The sender of the NEW_CONNECTION_ID frame MAY remove the connection IDs after 3 +PTO, even if the peer has not retired them yet. The 3-PTO timer starts on I forgot about RETIRE_CONNECTION_ID frame the first time I read this. Can you say something like: "not retired them with RETIRE_CONNECTION_ID yet." > @@ -5018,6 +5034,31 @@ sequence number, or if a sequence number is used for different connection IDs, the endpoint MAY treat that receipt as a connection error of type PROTOCOL_VIOLATION. +The Retire Prior To field is a requirement for the peer to retire all connection +IDs with a sequence number less than the specified value. This includes the +initial and preferred_address transport parameter connection IDs. The peer +SHOULD immediately retire all the connection IDs. + +The sender of the NEW_CONNECTION_ID frame MAY remove the connection IDs after 3 +PTO, even if the peer has not retired them yet. The 3-PTO timer starts on +acknowledgement of the packet containing the NEW_CONNECTION_ID frame. Continued +use of the retired connection IDs after this point will likely result in a +stateless reset being sent. + +In order to prevent a stateless reset sent in response to a heavily delayed Rewording suggestion: "In order to prevent a heavily delayed packet with a retired connection ID from eliciting a stateless reset that closes the connection, the stateless reset token...." > @@ -5018,6 +5034,31 @@ sequence number, or if a sequence number is used for different connection IDs, the endpoint MAY treat that receipt as a connection error of type PROTOCOL_VIOLATION. +The Retire Prior To field is a requirement for the peer to retire all connection +IDs with a sequence number less than the specified value. This includes the +initial and preferred_address transport parameter connection IDs. The peer +SHOULD immediately retire all the connection IDs. + +The sender of the NEW_CONNECTION_ID frame MAY remove the connection IDs after 3 +PTO, even if the peer has not retired them yet. The 3-PTO timer starts on +acknowledgement of the packet containing the NEW_CONNECTION_ID frame. Continued +use of the retired connection IDs after this point will likely result in a +stateless reset being sent. It may be worth adding a paragraph for the receiver of the NEW_CONNECTION_ID frame about stateless reset. ie: "If a stateless reset is received in response to a retired connection ID, the reset SHOULD be ignored and the receiver should immediately switch to a connection ID that has not been retired if it has not done so already." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2769#pullrequestreview-248359629
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- [quicwg/base-drafts] Request to Retire Locally Is… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Igor Lubashev
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Igor Lubashev
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson