Date: Sun, 19 Jan 2020 23:11:09 -0800
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5DMUM2KFAWRWRVHSF4GKCQ3EVBNHHCBWRIJQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3354/review/345110609@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3354@github.com>
References: <quicwg/base-drafts/pull/3354@github.com>
Subject: Re: [quicwg/base-drafts] Better describe the use of Preferred Address
 (#3354)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e25528d7545b_3f23f9c130cd96c7019a";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hS2socQ8tRPiJYwpjRVwiNS1VRA>


----==_mimepart_5e25528d7545b_3f23f9c130cd96c7019a
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

kazuho commented on this pull request.



> @@ -2194,11 +2194,13 @@ linked by any other entity.
 At any time, endpoints MAY change the Destination Connection ID they send to a
 value that has not been used on another path.
 
-An endpoint MUST use a new connection ID if it initiates connection migration as
-described in {{initiating-migration}} or probes a new network path as described
-in {{probing}}.  An endpoint MUST use a new connection ID in response to a
-change in the address of a peer if the packet with the new peer address uses an
-active connection ID that has not been previously used by the peer.
+An endpoint MUST use a new connection ID when it initiates connection migration
+as described in {{initiating-migration}} or {{preferred-address}}, or when it
+probes a new network path as described in {{probing}}, and MUST NOT reuse

The problem with the existing text is that while it says that a new connection ID MUST be used when "initiating" a migration, or probing, it does not forbid reuse of a CID (that has previously used on a different path) once the path is being validated.

That's is why I added the "MUST NOT" without splitting the sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3354#discussion_r368394945
----==_mimepart_5e25528d7545b_3f23f9c130cd96c7019a
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@kazuho</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3354#discussion_r368394945">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -2194,11 +2194,13 @@ linked by any other entity.
 At any time, endpoints MAY change the Destination Connection ID they send to a
 value that has not been used on another path.
 
-An endpoint MUST use a new connection ID if it initiates connection migration as
-described in {{initiating-migration}} or probes a new network path as described
-in {{probing}}.  An endpoint MUST use a new connection ID in response to a
-change in the address of a peer if the packet with the new peer address uses an
-active connection ID that has not been previously used by the peer.
+An endpoint MUST use a new connection ID when it initiates connection migration
+as described in {{initiating-migration}} or {{preferred-address}}, or when it
+probes a new network path as described in {{probing}}, and MUST NOT reuse
</pre>
<p>The problem with the existing text is that while it says that a new connection ID MUST be used when "initiating" a migration, or probing, it does not forbid reuse of a CID (that has previously used on a different path) once the path is being validated.</p>
<p>That's is why I added the "MUST NOT" without splitting the sentence.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications&amp;email_token=AFTOJKZF2QKMTLZBNF2GEHTQ6VFA3A5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSI7QUI#discussion_r368394945">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK72E7OAF34G3GGQ7EDQ6VFA3ANCNFSM4KIBEVSQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZKKK5SUI3ZR5C52LTQ6VFA3A5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSI7QUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications\u0026email_token=AFTOJKZF2QKMTLZBNF2GEHTQ6VFA3A5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSI7QUI#discussion_r368394945",
"url": "https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications\u0026email_token=AFTOJKZF2QKMTLZBNF2GEHTQ6VFA3A5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSI7QUI#discussion_r368394945",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e25528d7545b_3f23f9c130cd96c7019a--