Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)

Lucas Pardue <notifications@github.com> Tue, 21 January 2020 13:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98DE71200F7 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jan 2020 05:10:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.998
X-Spam-Level:
X-Spam-Status: No, score=-7.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jSgXIwd2tuBH for <quic-issues@ietfa.amsl.com>; Tue, 21 Jan 2020 05:10:00 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD2F81208A6 for <quic-issues@ietf.org>; Tue, 21 Jan 2020 05:10:00 -0800 (PST)
Received: from github-lowworker-2300405.va3-iad.github.net (github-lowworker-2300405.va3-iad.github.net [10.48.17.39]) by smtp.github.com (Postfix) with ESMTP id A471D8C0DC8 for <quic-issues@ietf.org>; Tue, 21 Jan 2020 05:09:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579612199; bh=tKgxm6yPSAwDy4EMW0JVLdjwKt8aMB01j8FQk4jdUck=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pbL6akMblDyjuL+YwIj8qFpar/4cGU2atkjcPRPvL7O0l2dJNWZoCR0s+S8wPUBP7 VrFMahTaFzlONC/xE7iRr9lxOu9eo61Yo201tBvLW+xWa/f8LNXvtSP983/O9CA7d3 anCoZWGYZziC4TNMqMHOlZj9jCGFaSIwS38yUx3s=
Date: Tue, 21 Jan 2020 05:09:59 -0800
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2EIABLAHHRYGMP6354GQVKPEVBNHHCBYJK2Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3360/review/345862710@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3360@github.com>
References: <quicwg/base-drafts/pull/3360@github.com>
Subject: Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e26f82795257_4d6e3fa0ca0cd96033654e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hS5WJSZaXGp6TJEf8vfLdtBndOY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2020 13:10:07 -0000

LPardue commented on this pull request.



> @@ -925,7 +925,9 @@ transferred. Endpoints MUST NOT consider these streams to have any meaning upon
 receipt.
 
 The payload and length of the stream are selected in any manner the
-implementation chooses.
+implementation chooses.  Implementations MAY terminate these streams cleanly,
+or MAY abruptly terminate them with an error code of the implementation's
+choice, including reserved error codes ({{http-error-codes}}).

We already say https://quicwg.org/base-drafts/draft-ietf-quic-http.html#section-8

> Because new error codes can be defined without negotiation (see Section 9), use of an error code in an unexpected context or receipt of an unknown error code MUST be treated as equivalent to H3_NO_ERROR. However, closing a stream can have other effects regardless of the error code

Closing a stream with the error code H3_CLOSED_CRITICAL_STREAM seems like an unexpected context to me. Martin makes the suggestion above to also treat reserved error values as H3_NO_ERROR.

By defining and exercising grease of error codes, we can help surface naiive implementations that react in the unfortunate way of your example. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3360#discussion_r368989867