Re: [quicwg/base-drafts] Recommend H3_NO_ERROR for early responses (#3208)

Mike Bishop <notifications@github.com> Fri, 08 November 2019 21:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC9EF12084D for <quic-issues@ietfa.amsl.com>; Fri, 8 Nov 2019 13:05:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u9aBOXOoCugs for <quic-issues@ietfa.amsl.com>; Fri, 8 Nov 2019 13:05:47 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E34B11200E0 for <quic-issues@ietf.org>; Fri, 8 Nov 2019 13:05:46 -0800 (PST)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id 170396A1C54 for <quic-issues@ietf.org>; Fri, 8 Nov 2019 13:05:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573247146; bh=PDWUWOaZ/7BQ1XEgEQ4bUYFiY2JOjf7bQJObY360E0s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KjqCQcfzi8dWxveqbjprgwNmebR7Epti5T2GC9uzlqK1W/UzD3cJz7xBaw1XXwI7I qf1+qHX0c8DROpE+Ec7HArSnfhxyZeihCx5HMQyWzbCsYqAk9LHcNcQWxcf2mmNb7P edtAfg2eIOpD8xPErFaGdqBRsHEJADg9R/WMREPU=
Date: Fri, 08 Nov 2019 13:05:46 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYODWD3C76CS3VFWVF32MFSVEVBNHHB6AI4HU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3208/review/314459400@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3208@github.com>
References: <quicwg/base-drafts/pull/3208@github.com>
Subject: Re: [quicwg/base-drafts] Recommend H3_NO_ERROR for early responses (#3208)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc5d8aa25e7_43c43f85764cd96c283179"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hSRp7OMijQKgxzt8_YKymQwM1DY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Nov 2019 21:05:49 -0000

MikeBishop commented on this pull request.



> @@ -424,13 +424,14 @@ H3_REQUEST_INCOMPLETE.
 A server can send a complete response prior to the client sending an entire
 request if the response does not depend on any portion of the request that has
 not been sent and received. When the server does not need to receive the
-remainder of the request, it MAY abort reading the request stream with error
-code H3_EARLY_RESPONSE, send a complete response, and cleanly close the
-sending part of the stream. Clients MUST NOT discard complete responses as a
-result of having their request terminated abruptly, though clients can always
-discard responses at their discretion for other reasons.  If the server sends a
-partial or complete response but does not abort reading, clients SHOULD continue
-sending the body of the request and close the stream normally.
+remainder of the request, it MAY abort reading the request stream, send a

The terminology is [in the transport spec](https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#rfc.section.2.4), and one of the operations is:
> abort reading of the stream and request closure, possibly resulting in a STOP_SENDING frame (Section 19.5).

I think rephrasing the second sentence to try and improve the linkage would be good, though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3208#discussion_r344366314