IETF Logo Mail Archive

Re: [quicwg/base-drafts] Recommend replacing, not changing, protocol components (#3206)

Martin Thomson <notifications@github.com> Mon, 11 November 2019 00:54 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 273681200E5 for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 16:54:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ay0p5rJ73WJm for <quic-issues@ietfa.amsl.com>; Sun, 10 Nov 2019 16:54:11 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6251212001A for <quic-issues@ietf.org>; Sun, 10 Nov 2019 16:54:11 -0800 (PST)
Date: Sun, 10 Nov 2019 16:54:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573433650; bh=nIOCIr35fkwBmLkxFCveWTAyxb9a3th+wMDGMmzSF50=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jeGNMnDJ6uYRM2Z+7xicQ2VE2rWDcwkfqSZNC0yci0QmglbLzC/LkDLwO/qkCRui7 KWZo4rDgNpiRz02z4tcNvY/1vDjQ1r37SQBtCi7en+Zg+BuQw1e07ZUYt7tCEUdZPH teTR/89ZcQ+Cl6/X4wmvg1AJxHBdR9HtdPZvdqLo=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7EXIQ5CE2XQVVTNFV32XR3FEVBNHHB6AHR2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3206/review/314656488@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3206@github.com>
References: <quicwg/base-drafts/pull/3206@github.com>
Subject: Re: [quicwg/base-drafts] Recommend replacing, not changing, protocol components (#3206)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc8b132a65ff_17113f85e8acd96c6181d3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/h_0X58WOdG5NEc0y0vlnSvhTGBk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Nov 2019 00:54:13 -0000

martinthomson approved this pull request.



> @@ -1485,8 +1485,9 @@ requirement and SHOULD be treated as an error.
 Extensions that could change the semantics of existing protocol components MUST
 be negotiated before being used.  For example, an extension that changes the
 layout of the HEADERS frame cannot be used until the peer has given a positive
-signal that this is acceptable. In this case, it could also be necessary to
-coordinate when the revised layout comes into effect.
+signal that this is acceptable.  Coordinating when such a revised layout comes
+into effect could prove complex.  As such, allocating new identifiers for
+alternate versions of existing protocol elements is likely to be more effective.

```suggestion
new definitions of existing protocol elements is likely to be more effective.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3206#pullrequestreview-314656488

v2.23.0 | Report a Bug | By Email