Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPOSNE frames, avoid buffering (#2729)

Martin Thomson <notifications@github.com> Tue, 21 May 2019 07:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00B5B12007C for <quic-issues@ietfa.amsl.com>; Tue, 21 May 2019 00:33:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.011
X-Spam-Level:
X-Spam-Status: No, score=-8.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wACQjwSBMWMO for <quic-issues@ietfa.amsl.com>; Tue, 21 May 2019 00:33:31 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EF1B120021 for <quic-issues@ietf.org>; Tue, 21 May 2019 00:33:31 -0700 (PDT)
Date: Tue, 21 May 2019 00:33:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1558424010; bh=u0Z4VbO0XDMcCXraESI9hom1mYFo3w676Vhs3bqb0aU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=AzxOolF4VqHKsM2zBSV2AtTUJf9fl0CvhZR3JPxeHytf920D/K44UUQ+QKzTm5QSj v58o+HXVAl0vxCOqTYGrvSArcAW1LHalTZl9UqVbs/nM58hXPCc1kMXZsn6BEZ5SXj 8/0sgIYA58OQUMdGHvijq+r/r4wiP/bV39Z7BbqQ=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK65NGRR6KOFVEE3LJ526DOEVEVBNHHBVGEZF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2729/review/239867076@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2729@github.com>
References: <quicwg/base-drafts/pull/2729@github.com>
Subject: Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPOSNE frames, avoid buffering (#2729)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ce3a9ca32919_36563facfd0cd96c28906c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hbXqd1PH1EYj_gda1od0UcP7QJ4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 May 2019 07:33:33 -0000

martinthomson commented on this pull request.

Did you want to base this on the other PR? Merge conflicts suck. 

> @@ -1722,6 +1722,10 @@ it can associate the peer's response with the corresponding PATH_CHALLENGE.
 
 On receiving a PATH_CHALLENGE frame, an endpoint MUST respond immediately by
 echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame.
+An endpoint MUST NOT store or retransmit a PATH_RESPONSE frame, as a new

```suggestion

An endpoint MUST NOT store or retransmit a PATH_RESPONSE frame, as a new
```

> @@ -1722,6 +1722,10 @@ it can associate the peer's response with the corresponding PATH_CHALLENGE.
 
 On receiving a PATH_CHALLENGE frame, an endpoint MUST respond immediately by
 echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame.
+An endpoint MUST NOT store or retransmit a PATH_RESPONSE frame, as a new
+PATH_CHALLENGE frame will be sent if another PATH_RESPONSE frame is needed.  An
+endpoint MAY choose to limit the number of pending PATH_RESPONSE frames

I think that this amounts to ignoring PATH_CHALLENGE. It might be better to say that instead. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2729#pullrequestreview-239867076