Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)

[janaiyengar <[e-mail]>]

janaiyengar commented on this pull request.



> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
 
+max_connection_ids (0x000e):
+
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

You have the two sides mixed up. This param should convey the max that _this_ endpoint is willing to store. For clarity, I also suggest that you explicitly call out who is sending the new connection IDs: "... includes only connections IDs sent by the peer..."

> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
 
+max_connection_ids (0x000e):
+
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

Ugh. I don't like including the CID with SPA in this count for the reason @ianswett mentions. Given that the only CID that a client will _store_ is the one that is sent on an SPA, and even that will get used immediately (or get discarded), I think it's reasonable to say that the number of _stored_ CIDs is limited by max_connection_ids.

>  An endpoint SHOULD ensure that its peer has a sufficient number of available and
-unused connection IDs.  While each endpoint independently chooses how many
-connection IDs to issue, endpoints SHOULD provide and maintain at least eight
-connection IDs.  The endpoint SHOULD do this by always supplying a new
-connection ID when a connection ID is retired by its peer or when the endpoint
-receives a packet with a previously unused connection ID.  Endpoints that
+unused connection IDs. Endpoints store received connection IDs for future use.
+An endpoint uses a transport parameter to advertise the maximum number of
+connection IDs it can store for future use. An endpoint MUST NOT provide more
+connection IDs than this limit. An endpoint MUST treat receipt of more than this
+number of connection IDs as an error of type CONNECTION_ID_LIMIT_ERROR. If an

Do we want a new error for this, or can we live with PROTOCOL_VIOLATION?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1998#pullrequestreview-186755366