Re: [quicwg/base-drafts] Handshake Flow Control can result in hung connections (#1764)
ianswett <notifications@github.com> Tue, 18 September 2018 18:43 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0D5F61274D0 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 11:43:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MlLIJJGpm4Ek for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 11:43:43 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BF311200D7 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 11:43:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=pEN69LIr1DlmHNs2KfnypQTS7Nc=; b=ocdtuRh3xe4mLwv5 YdcTWBDwz5JQkN8wrTaO6OPIjojwh1/Zv055yhUZxDSOOueIM3l7pp1uh+1c2T4O 1wV9voZtemfy0Jysfk1oIXJ8+9YZlk6jBUHhUYulCYCRG0VWBs5zHrODDZ0jZcUj ainibYOENNcIkAxIxlt4/6aqx3w=
Received: by filter0942p1las1.sendgrid.net with SMTP id filter0942p1las1-6290-5BA1475E-2 2018-09-18 18:43:42.190928054 +0000 UTC m=+413544.618086861
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id VvGDrdCFT8iGRpzIjaXVgQ for <quic-issues@ietf.org>; Tue, 18 Sep 2018 18:43:42.076 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id F31F516002A for <quic-issues@ietf.org>; Tue, 18 Sep 2018 11:43:41 -0700 (PDT)
Date: Tue, 18 Sep 2018 18:43:42 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7dadb82b190f54c188c876de93fd4720996ce6b592cf0000000117b9095d92a169ce1589cd31@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1764/422503904@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1764@github.com>
References: <quicwg/base-drafts/issues/1764@github.com>
Subject: Re: [quicwg/base-drafts] Handshake Flow Control can result in hung connections (#1764)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba1475deefba_42d03fea5bad45b4974fc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2IG5RnxcLfPr2Z4tZfl/Ca18ymbepQLSTCPb GCCEHXFF/KF9pIGg32fXtEi/8Rpu1AvT747azeKXuwYlPDz80G2mlPICl0pRMN3BdLcCMGfmSC7ZLR M82905lCk1bXaqP3OLDNukkgRPgMw6kEOONSwLwyCRQ66pEJDUyYvFVEPw==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hjff6FYWlSpoiEKfiaQb8bDWQbc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 18:43:45 -0000
I would prefer to call this a limit on handshake amplification, not flow control FWIW, but the outlined solution seems reasonable. Another option might be if once the client has handshake keys, if there is nothing to send immediately, send a PING in a HANDSHAKE packet to prove the client is on path. And until the client has handshake keys, it needs to retransmit the Initial, as you outlined above. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/1764#issuecomment-422503904
- [quicwg/base-drafts] Handshake Flow Control can r… martinduke
- Re: [quicwg/base-drafts] Handshake Flow Control c… ianswett
- Re: [quicwg/base-drafts] Handshake loss recovery … martinduke
- Re: [quicwg/base-drafts] Handshake loss recovery … Martin Thomson
- Re: [quicwg/base-drafts] Handshake loss recovery … martinduke
- Re: [quicwg/base-drafts] Handshake loss recovery … martinduke
- Re: [quicwg/base-drafts] Handshake loss recovery … Martin Thomson
- Re: [quicwg/base-drafts] Handshake loss recovery … ianswett
- Re: [quicwg/base-drafts] Handshake loss recovery … martinduke
- Re: [quicwg/base-drafts] Handshake loss recovery … MikkelFJ
- Re: [quicwg/base-drafts] Handshake loss recovery … ianswett
- Re: [quicwg/base-drafts] Handshake loss recovery … Martin Thomson
- Re: [quicwg/base-drafts] Handshake loss recovery … janaiyengar