Re: [quicwg/base-drafts] Up to two full-sized datagrams, not packets (#2915)

MikkelFJ <notifications@github.com> Sun, 21 July 2019 19:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 31A4E120134 for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 12:50:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGcSH8twR4-R for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 12:50:14 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EFCA12012C for <quic-issues@ietf.org>; Sun, 21 Jul 2019 12:50:14 -0700 (PDT)
Date: Sun, 21 Jul 2019 12:50:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563738614; bh=M7CZtdlTc6/O71ozffdYcQUybru1YiljhQzZVpr1coo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mQsbTOstRRhMLRd55/BD0iwQZA3Jprv1oHvlo7SUNbZWmOU71PBW19kGSa0nkVpiT 3ajaHoAF5Ro/SOpdvSPlW3kFXsDo91yiDMFnpGZ+6FvE/jKmRInclue9Vh2vnEzRup sY1LuG9ofgPEY4Z1x4WwKiByIcnOwwP2SjLYR4QA=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4HPM23LIFTFMATWVF3IH2HLEVBNHHBYD4VYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2915/review/264551850@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2915@github.com>
References: <quicwg/base-drafts/pull/2915@github.com>
Subject: Re: [quicwg/base-drafts] Up to two full-sized datagrams, not packets (#2915)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d34c1f5ab8c9_2c3b3fcbc86cd968405051"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hkkM_ykKszjZKP4gQhulSnAv71Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jul 2019 19:50:16 -0000

mikkelfj commented on this pull request.



> @@ -598,8 +598,8 @@ discarded.
 
 When a PTO timer expires, a sender MUST send at least one ack-eliciting packet
 as a probe, unless there is no data available to send.  An endpoint MAY send up
-to two ack-eliciting packets, to avoid an expensive consecutive PTO expiration
-due to a single packet loss.
+to two full sized datagrams containing ack-eliciting packets, to avoid an
+expensive consecutive PTO expiration due to a single lost datagram.
 

Ah, I am confusing UDP datagrams and packets.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2915#discussion_r305633152