[quicwg/base-drafts] clients always must regenerate client hello (#826)

jpinner-lyft <notifications@github.com> Tue, 03 October 2017 22:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4DE9A1331DC for <quic-issues@ietfa.amsl.com>; Tue, 3 Oct 2017 15:00:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.615
X-Spam-Level:
X-Spam-Status: No, score=-5.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BJ7W4BARoPSJ for <quic-issues@ietfa.amsl.com>; Tue, 3 Oct 2017 15:00:01 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext4.iad.github.net [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C23C4132125 for <quic-issues@ietf.org>; Tue, 3 Oct 2017 14:59:59 -0700 (PDT)
Date: Tue, 03 Oct 2017 14:59:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1507067999; bh=xJqosp5QCFvnt4DKLcD1IXqjVKeu5t/R+8HNiV7tALE=; h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=vh5QEYUOP+aMjml+fSyb0EGva8s08ftMyxsgp1tkcDGDiY5hTMjfyMwf+UoILtk8O RsYwqBLDIr5RRIV2c7m+FBKT5Tx1MJv67qG5p36sqvYJ64rmIAVcAj1bcb50s/up/d rd0Cr4ZsLC+yrIr30Vs6X/P/itIi7OZgWUDIWMuM=
From: jpinner-lyft <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6d471d196b0070df626739b2df0b50d2bc856ec092cf0000000115ebca5e92a169ce0fa70520@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/826@github.com>
Subject: [quicwg/base-drafts] clients always must regenerate client hello (#826)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59d4085eeeeba_3cfd3fad31a52f3029758"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: jpinner-lyft
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hpjs_FXZ5npx7Gjy1LNBhxmTJlc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Oct 2017 22:00:02 -0000

The text in Sec 7.1 that details client handling of a version negotiation packet is not accurate:

"Though the contents of a packet might not change in response to version negotiation, a client MUST increase the packet number it uses on every packet it sends."

In particular because the transport parameters must be updated to reflect the version negotiation, the contents of the client initial packet must change. Also the first packet number will never be acknowledged so increasing the packet number by one to signify a retransmission does not make sense.

In particular the packet number should be reinitialized as specified in Sec 5.4.1 since as stated above, new contents must be created.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/826