Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

I think that this is fine, but wonder if a better definition would help.  Or maybe "end offset" - the offset of the end of the stream.

"offset" was chosen specifically because that is what matters.  And it allows for gaps.  So a more careful definition is probably needed either way.  I've a suggestion inline that uses "final size", but I think that "end offset" might still be better.

>  
-The final offset is the count of the number of bytes that are transmitted on a
-stream.  For a stream that is reset, the final offset is carried explicitly in a
-RESET_STREAM frame.  Otherwise, the final offset is the offset of the end of the
-data carried in a STREAM frame marked with a FIN flag, or 0 in the case of
-incoming unidirectional streams.
+The final size is the amount of data that is transmitted on a stream.  For a

This is the critical piece.  We have to allow for gaps, so I suggest:

```suggestion
The final size is the amount of flow control credit that is consumed by a
stream.  Assuming that every contiguous byte on the stream was sent, the final
size is the number of bytes sent.  More generally, this is one higher than the
largest byte offset sent on the stream.

For a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#pullrequestreview-188891346