Re: [quicwg/base-drafts] Rephrase size requirement for Initial packets (#2520)
Martin Thomson <notifications@github.com> Thu, 14 March 2019 03:10 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D4CE13125D for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 20:10:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3RxE8Shy_ef for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 20:10:51 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D4C5813125A for <quic-issues@ietf.org>; Wed, 13 Mar 2019 20:10:50 -0700 (PDT)
Date: Wed, 13 Mar 2019 20:10:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552533049; bh=hs0dibL27TGDGrnY1D1/8vhe2aKTR9ZNWQHcHxgAYHM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oVwbxZx7xdd280DnSZduaRC9oNwCSrtLXoacCWRk7JipNDxsPHoQhP7sKg7iMOUjB vLyZ/yzuFFUMOSTHRPDHV4LjyI2NtzurEzrai4sLClZ0h5nHl4jTv5UZD+ep2HReUT IhlAqHn003uIpns6AGKLEN2cri/YhWBidSLn/rx8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0ac4f9a5495c7a1076da599a0e01e21c6dd31de892cf0000000118a1883992a169ce19118bed@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2520/review/214302703@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2520@github.com>
References: <quicwg/base-drafts/pull/2520@github.com>
Subject: Re: [quicwg/base-drafts] Rephrase size requirement for Initial packets (#2520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c89c639c85f9_30803fc5678d45c04467e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/htr1OL-mqX1DtgfbFjXJvN1gU9w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Mar 2019 03:10:52 -0000
martinthomson approved this pull request. A potential friendly amendment, but then we should proceed. I would say after confirming with chairs, because there was a pretty strong design decision involved here, but technically this is only an editorial change. > @@ -1468,10 +1468,11 @@ magnitude of any amplification attack that can be mounted using spoofed source addresses. In determining this limit, servers only count the size of successfully processed packets. -Clients MUST pad UDP datagrams that contain only Initial packets to at least -1200 bytes. Once a client has received an acknowledgment for a Handshake packet -it MAY send smaller datagrams. Sending padded datagrams ensures that the server -is not overly constrained by the amplification restriction. +Clients MUST ensure that UDP datagrams containing Initial packets are sized to +at least 1200 bytes, padding packets in the datagram if necessary. Once a ```suggestion at least 1200 bytes, adding padding to packets in the datagram as necessary. Once a ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2520#pullrequestreview-214302703
- [quicwg/base-drafts] Rephrase size requirement fo… Jana Iyengar
- Re: [quicwg/base-drafts] Rephrase size requiremen… Kazuho Oku
- Re: [quicwg/base-drafts] Rephrase size requiremen… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Rephrase size requiremen… ianswett
- Re: [quicwg/base-drafts] Rephrase size requiremen… Martin Thomson
- Re: [quicwg/base-drafts] Rephrase size requiremen… Martin Thomson
- Re: [quicwg/base-drafts] Rephrase size requiremen… Tommy Pauly
- Re: [quicwg/base-drafts] Rephrase size requiremen… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Rephrase size requiremen… Jana Iyengar
- Re: [quicwg/base-drafts] Rephrase size requiremen… Jana Iyengar
- Re: [quicwg/base-drafts] Rephrase size requiremen… Jana Iyengar
- Re: [quicwg/base-drafts] Rephrase size requiremen… Jana Iyengar
- Re: [quicwg/base-drafts] Rephrase size requiremen… Jana Iyengar