Re: [quicwg/base-drafts] Added a word of caution before abandoning Initial packets (#3416)

Christian Huitema <notifications@github.com> Wed, 05 February 2020 15:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CEF341200EC for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 07:04:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZbBAd1u1WyOD for <quic-issues@ietfa.amsl.com>; Wed, 5 Feb 2020 07:04:40 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1290D1200EB for <quic-issues@ietf.org>; Wed, 5 Feb 2020 07:04:40 -0800 (PST)
Date: Wed, 05 Feb 2020 07:04:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580915079; bh=4tASVYkkRNdsuT4EodUQKJI1SoSNhBEDQx4wmgAWJb4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uobB6bRAtUgpgmfVP1+4s3bJrtCg6RxzBhvYq3cJsIUKUuFOfnH9YNMZFFahcmnvx LElQCz9mi0kN8HWPbO9Fj/DFtl+N+WrWvo1Hyhig5Xmg4pT1n16uyf42jHdfTU424+ f6o89mtFsw7kC20DS0pLelCi8KqOO7omAb+lrM+k=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4MEXRAJQHWV4PV32F4JAGAPEVBNHHCCZCBQI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3416/review/353786766@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3416@github.com>
References: <quicwg/base-drafts/pull/3416@github.com>
Subject: Re: [quicwg/base-drafts] Added a word of caution before abandoning Initial packets (#3416)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3ad9874522d_73c83fd2980cd960594dc"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hvlf9Sxly9bIGdz7ZWO0PUuh204>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 15:04:42 -0000

huitema commented on this pull request.



> @@ -3700,7 +3700,9 @@ when it receives its first Handshake packet.  Though packets might still be in
 flight or awaiting acknowledgment, no further Initial packets need to be
 exchanged beyond this point.  Initial packet protection keys are discarded (see
 Section 4.10 of {{QUIC-TLS}}) along with any loss recovery and congestion
-control state (see Sections 5.3.1.2 and 6.9 of {{QUIC-RECOVERY}}).
+control state (see Sections 5.3.1.2 and 6.9 of {{QUIC-RECOVERY}}). This is safe
+because of the additional safeguards against loss of Handshake packets in

The peer having Handshake keys is not sufficient. The peer also needs to ensure that packets are repeated.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3416#discussion_r375309655