Re: [quicwg/base-drafts] Revalidation for ECN (#4037)

Martin Thomson <notifications@github.com> Mon, 24 August 2020 02:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3DE2F3A0938 for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 19:02:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uiLeep9mpicg for <quic-issues@ietfa.amsl.com>; Sun, 23 Aug 2020 19:02:08 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9D263A0933 for <quic-issues@ietf.org>; Sun, 23 Aug 2020 19:02:08 -0700 (PDT)
Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id 94145900EC3 for <quic-issues@ietf.org>; Sun, 23 Aug 2020 19:02:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598234527; bh=bhnZVdjtd3/2gICUHj0sCXIvrWT/QxzaY5pPIh6u18c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I9SKE2emWKrjvMBJaja8LNcYwOaRXneuD2QmFzmZ6nA99dCbhB0UfV4+FUBM1kc1S k9xXtRbkhCJKtzR1uVqqmeebrmnCMrqBPMcXn/ZpvEx11YxaDQYCxyP9Bz//v3bA+w lvPXTVndembeeInP2S5tOgdB3jS3tbAVnqDHE7Js=
Date: Sun, 23 Aug 2020 19:02:07 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6H2AJMK5V7EQPCL7F5J4AJ7EVBNHHCRKTJ7Y@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4037/review/473077762@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4037@github.com>
References: <quicwg/base-drafts/pull/4037@github.com>
Subject: Re: [quicwg/base-drafts] Revalidation for ECN (#4037)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f431f9f84b14_6c09196411285d3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/hxelkpX-GsrsInAKAsiMzN6eUAE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Aug 2020 02:02:10 -0000

@martinthomson commented on this pull request.



> @@ -3892,6 +3889,7 @@ errors are detected.
 Endpoints validate ECN for packets sent on each network path independently.  An
 endpoint thus validates ECN on new connection establishment, when switching to a
 server's preferred address, and on active connection migration to a new path.
+If validation fails, an endpoint could also periodically attempt validation.

This is a could and not a SHOULD because making a recommendation would require us to make that recommendation actionable.  That means describing the circumstances under which revalidation is desirable.

I realize that not all routes are static, but you would have to establish a case for revalidation in order to make any sort of statement with normative force.

> @@ -3843,11 +3843,8 @@ instead of dropping it.  Endpoints react to congestion by reducing their sending
 rate in response, as described in {{QUIC-RECOVERY}}.
 
 To use ECN, QUIC endpoints first determine whether a path supports ECN marking
-and the peer is able to access the ECN codepoint in the IP header.  A network
-path does not support ECN if ECN marked packets get dropped or ECN markings are
-rewritten on the path. An endpoint validates the use of ECN on the path, both
-during connection establishment and when migrating to a new path
-({{migration}}).
+and the peer is able to access the ECN codepoint in the IP header; see
+{{ecn-validation}}.

I don't see how this text contradicts.  Given that it is old, all I'm reading from this feedback is a preference to keep text that better belongs in the referenced section.  And that section already concentrates on the path aspects (dropping, corruption).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4037#discussion_r475304700