Date: Thu, 19 Apr 2018 16:45:05 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abbd74ad3e67a39e4e0c8b0710bf88d3766154198a92cf0000000116f0ec0192a169ce12d68139@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1307/review/113813136@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1307@github.com>
References: <quicwg/base-drafts/pull/1307@github.com>
Subject: Re: [quicwg/base-drafts] Change Packet Number Gap to Packet Number
 Offset (#1307)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ad92a012bef5_37352aec34adcf506349b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/i8IKpNzWfejoz3l_oYYFejUj_Ww>


----==_mimepart_5ad92a012bef5_37352aec34adcf506349b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -832,6 +832,27 @@ Use of a secure random number generator {{?RFC4086}} is not necessary for
 generating the initial packet number, nor is it necessary that the value be
 uniformly distributed.
 
+### New Connection ID Packet Numbers
+
+Packets with with new connection IDs have special rules for encoding the packet
+number in the headers.  They use an offset (see {{packet-number-offset}}) to
+transform the packet number via the following:

Why does this only apply to new connection IDs? Wouldn't it be easier to apply this transformation to every packet number?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1307#pullrequestreview-113813136
----==_mimepart_5ad92a012bef5_37352aec34adcf506349b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1307#discussion_r182914702">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -832,6 +832,27 @@ Use of a secure random number generator {{?RFC4086}} is not necessary for
 generating the initial packet number, nor is it necessary that the value be
 uniformly distributed.
 
+### New Connection ID Packet Numbers
+
+Packets with with new connection IDs have special rules for encoding the packet
+number in the headers.  They use an offset (see {{packet-number-offset}}) to
+transform the packet number via the following:
</pre>
<p>Why does this only apply to new connection IDs? Wouldn't it be easier to apply this transformation to every packet number?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1307#pullrequestreview-113813136">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqwM7WRQZIw9vvCnanmVCovxNcYhrks5tqSGBgaJpZM4Tch4q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq2GBmZjXmZaf94_OWs-83myQMnt9ks5tqSGBgaJpZM4Tch4q.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/1307#pullrequestreview-113813136"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@marten-seemann commented on #1307"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1307#pullrequestreview-113813136"}}}</script>
----==_mimepart_5ad92a012bef5_37352aec34adcf506349b--