[quicwg/base-drafts] Transition to half closed local should probably happen on FIN ack (#571)

Subodh Iyengar <notifications@github.com> Sun, 04 June 2017 07:02 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8C8DA126D05 for <quic-issues@ietfa.amsl.com>; Sun, 4 Jun 2017 00:02:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.8
X-Spam-Level:
X-Spam-Status: No, score=-4.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1SGq3MdzwSLW for <quic-issues@ietfa.amsl.com>; Sun, 4 Jun 2017 00:02:01 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 07E98124217 for <quic-issues@ietf.org>; Sun, 4 Jun 2017 00:02:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=YyiHTHHbXyOK/7BQdl625R5EfR0=; b=Sfsqid+l/20nNLlW 8pE+rbvEYHB4+QOkV+EzKnuy28OGOtGPU++x+jID7YWQ1NXtyTS2G6FX17xiCsT4 KcrU21D2s0ik8Q2M49Ev8/Bzffwdi15KRNvKejSrsIvLejUvihuHQCurQ1tAfU/+ GkuqihNBS8Z64eqOdY09ApZR3AU=
Received: by filter0552p1mdw1.sendgrid.net with SMTP id filter0552p1mdw1-26879-5933B067-18 2017-06-04 07:01:59.358834615 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id 7RCzIXr7RWWQfypa_vFruQ for <quic-issues@ietf.org>; Sun, 04 Jun 2017 07:01:59.305 +0000 (UTC)
Date: Sun, 04 Jun 2017 00:01:59 -0700
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab00a91130ad0a3e40e31f4d1963e137168ac7f0d392cf00000001154b726792a169ce0de9a623@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/571@github.com>
Subject: [quicwg/base-drafts] Transition to half closed local should probably happen on FIN ack (#571)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5933b0671c4ef_7a7f3fdceaaddc3c37321"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2XPcSlPz3Vjpc+lthbC8e+qScUfrQMBqF602 9Ilc9TSrlI0YQ3OoFAjagqvCG99H9xb+lHvlUGozmVFPvYmCUFgaGuckcfHXLsB2eZgF6mddfY1wIb VcCJvIqjO77CTVOWwlPxQnUTE3Da5lDjTR55Qsj7IbyfBK/8O4mo5pHSKh+O4vSBeRXbsTHmAdboSH Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/i8r6_WYIZl4EkQonp161IqsRB64>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jun 2017 07:02:02 -0000

in 10.2.2. 
" An endpoint sending an FIN flag causes the stream state to become “half-closed (local)”. An endpoint receiving a FIN flag causes the stream state to become “half-closed (remote)” once all preceding data has arrived"

this seems to suggest that a sender will transition to half closed immediately after sending a FIN. Is that intentional? 

It seems that it would be better for the sender to transition to FIN only after getting the ACK otherwise you'd get into a case where:

Sender sends FIN -> transitions to half closed local
Receiver races with a RST -> sender has sent the FIN, so doesn't send a RST stream is response
Sender transitions to closed
FIN gets lost

However now that the sender is in closed it might still have to retransmit the FIN. Making the sender wait on FIN ack to transition to half closed local seems better, that way if the FIN is not ACKed, the sender could just go into half closed remote like normal when it gets the RST.

I like the idea of closed state being a terminal state where no additional work is needed from the sender.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/571