Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)

Martin Thomson <notifications@github.com> Thu, 03 August 2017 02:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE2AE126D46 for <quic-issues@ietfa.amsl.com>; Wed, 2 Aug 2017 19:21:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.799
X-Spam-Level:
X-Spam-Status: No, score=-9.799 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ujle1u4Fx5cJ for <quic-issues@ietfa.amsl.com>; Wed, 2 Aug 2017 19:21:02 -0700 (PDT)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext2.iad.github.net [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3649812426E for <quic-issues@ietf.org>; Wed, 2 Aug 2017 19:21:02 -0700 (PDT)
Date: Wed, 02 Aug 2017 19:21:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1501726861; bh=OSI7z7BuMxMEzEM96fjYXdllO8g3zjgC5yrAy84PIMY=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1tdTQ6WyGlCe0uL2aWqoIri6xuWxysbcLVFedvvVf42HTOSMwYeZb1qkBLpzBylzu bDvnsaeS0TQ0lJnTAQCTeaAvZPGHkHD+5Jd0fQ5uw4y8uWdXBLVJ+1EGZKC8zNDU2M mGqYExx7gXsnYCH9T7YR3Cfd8VbOE4Cm/ZXSYBhg=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4fce0dab187f9fb9c159d7445d9bf3d695b1fd9892cf00000001159a4a8d92a169ce0d7b2095@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/498/review/53980297@github.com>
In-Reply-To: <quicwg/base-drafts/pull/498@github.com>
References: <quicwg/base-drafts/pull/498@github.com>
Subject: Re: [quicwg/base-drafts] Version validation fields can't move or change (#498)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5982888d6db03_119783f8fb2247c38189515"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iHoowQv0YuYWAEAWBhuRUnUuH1A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 02:21:04 -0000

martinthomson commented on this pull request.



> @@ -1232,6 +1232,15 @@ client MUST terminate with a VERSION_NEGOTIATION_ERROR error code if
 version negotiation occurred but it would have selected a different version
 based on the value of the supported_versions list.
 
+When an endpoint accepts multiple QUIC versions, it can potentially interpret
+transport parameters as they are defined by any of the QUIC versions it
+supports. Since the QUIC protocol relies on transport parameters for
+authenticating the version, the position and the format of the version fields in
+transport parameters MUST be consistent across all QUIC versions supported by
+the client. If a version of QUIC needs to define a new format for transport
+parameters, it MUST define and use a new TLS extension for transport parameters

This is still the right place for the text, because it is talking specifically about version downgrade and how those are detected. Ian's comment is easy to address.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/498#discussion_r131040790