Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)

Jana Iyengar <notifications@github.com> Wed, 15 April 2020 00:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 872E83A13A8 for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 17:46:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.649
X-Spam-Level:
X-Spam-Status: No, score=-1.649 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sYmh6WdGtqtd for <quic-issues@ietfa.amsl.com>; Tue, 14 Apr 2020 17:46:15 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C31943A13A7 for <quic-issues@ietf.org>; Tue, 14 Apr 2020 17:46:14 -0700 (PDT)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id F135F1C07FE for <quic-issues@ietf.org>; Tue, 14 Apr 2020 17:46:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586911573; bh=GN+KaRgw6QFN0azqWZza5KBYc4Lng9Ngh8pgRwoInxo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mzqxsMUTnFMwrHtX26h2vPh309VZTLRjoyzxSuXmtthjkQIHJiDvanlPFGB1MhENB QncGIa/hplhZMEpZHaUrPsBKYxgjl5C2XgnoKBvcXfuH1+NkTzxa8Z/9z0GUwuM1FV qoaN68KEhPS80i5w/BMGhHDTQCbgVQe0LkjKICzY=
Date: Tue, 14 Apr 2020 17:46:13 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZQCFHVLOZKNUUF2N4UI5FLEVBNHHCHD4D3E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3572/review/393387097@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3572@github.com>
References: <quicwg/base-drafts/pull/3572@github.com>
Subject: Re: [quicwg/base-drafts] Adaptive thresholds are useful (#3572)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e965955e1336_1883f8b266cd9642677ac"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iRMKgZcXeNvlI0jbCGPK6UMhfRc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 00:46:17 -0000

@janaiyengar commented on this pull request.

Slight rewording

> +detect spurious losses.  Increasing reordering thresholds after losses
+are spuriously detected have proven useful in TCP, such	as TCP-NCR
+{{?RFC4653}}, and are expected to be equally useful in QUIC.

```suggestion
detect spurious losses. Increasing reordering thresholds after spurious
detection of losses can make the transport more robust to reordering,
as TCP-NCR {{?RFC4653}} does for TCP. Such mechanisms are
expected to make QUIC more robust to reordering as well.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3572#pullrequestreview-393387097