IETF Logo Mail Archive

Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)

Martin Thomson <notifications@github.com> Thu, 02 July 2020 01:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DC093A12C2 for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 18:05:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zbuC7EI7eyCX for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 18:05:30 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D09C23A12AD for <quic-issues@ietf.org>; Wed, 1 Jul 2020 18:05:29 -0700 (PDT)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id E651EA006B for <quic-issues@ietf.org>; Wed, 1 Jul 2020 18:05:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1593651928; bh=TTScWvUIrlJVIIvj3x00ToNp5c0rJh8P1MNGYwCf3CA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bIgswsc3svGSgYxpC3lQAtUQrj01A7+0l6J1fDHtbMBbcDxTA22for8i8jUWhi9u+ 0bPoRwriomQ0e7rTw0KKVbD32QpUXUVU24bCwJ87qAJZ8LmP6H6zVP3dFEk7dOCkK7 bkR/cA+uUMi+LfJXLrlIZBxYclfG+h70HlM1EvJk=
Date: Wed, 01 Jul 2020 18:05:28 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4MVZ36A3BFEOEDHGN5BEJ5REVBNHHCMZ3PEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3785/review/441285063@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3785@github.com>
References: <quicwg/base-drafts/pull/3785@github.com>
Subject: Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5efd32d8d5f2d_383f3fd367ccd95c1334a5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ibCGJxPQZw3iy4gAXXOhLqdTFmQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2020 01:05:32 -0000

@martinthomson commented on this pull request.



> @@ -252,8 +252,9 @@ Packets for the same QUIC connection might use different connection ID values.
 
 ## Version
 
-QUIC versions are identified with a 32-bit integer, encoded in network byte
-order.  Version 0 is reserved for version negotiation (see
+The Version field contains a 32-bit integer, encoded in network byte order.

Only so that we can use numbers to talk about values.  TLS picked up this crazy {3, 3} notation that annoys the hell out of me.  People read that to mean that there are two discrete things with different semantics, when there is just one value and one semantic.  You could always write out the hex (as people now do for connection IDs), but then that's just a number.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3785#discussion_r448692625

v2.27.8 | Report a Bug | By Email | System Status