Date: Sat, 19 Jan 2019 00:34:20 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4aba2a1fe06cf054083547b9dccfc593fcd155f537092cf00000001185aa30c92a169ce17d8cc13@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2340/review/194349635@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2340@github.com>
References: <quicwg/base-drafts/pull/2340@github.com>
Subject: Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c42e10c8a1ee_56973fe0e2ad45b46489ce";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/icJD8cexNIvVUupvHa9HumzmuKE>


----==_mimepart_5c42e10c8a1ee_56973fe0e2ad45b46489ce
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -289,8 +289,15 @@ be subtracted from the RTT as long as the result is larger than the min_rtt.
 If the result is smaller than the min_rtt, the RTT should be used, but the
 ack delay field should be ignored.
 
-Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
-specified in {{?RFC6298}}.
+A sender calculates both smoothed RTT and RTT variance similar to those
+specified in {{?RFC6298}}, see {{on-ack-received}}.
+
+A sender might take multiple samples per RTT because ACK frames that are

Suggestion: "A sender will take multiple samples per RTT when ACK frames are received within an RTT that acknowledge larger packet numbers than before("

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635
----==_mimepart_5c42e10c8a1ee_56973fe0e2ad45b46489ce
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2340#discussion_r249238771">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -289,8 +289,15 @@ be subtracted from the RTT as long as the result is larger than the min_rtt.
 If the result is smaller than the min_rtt, the RTT should be used, but the
 ack delay field should be ignored.
 
-Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
-specified in {{?RFC6298}}.
+A sender calculates both smoothed RTT and RTT variance similar to those
+specified in {{?RFC6298}}, see {{on-ack-received}}.
+
+A sender might take multiple samples per RTT because ACK frames that are
</pre>
<p>Suggestion: "A sender will take multiple samples per RTT when ACK frames are received within an RTT that acknowledge larger packet numbers than before("</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq-WEl0OC9jvFxPdK7RiRY7bNPf6nks5vEtiMgaJpZM4aEVlj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1p49ET19OOM-nJ8ZhoqpK9b3OY4ks5vEtiMgaJpZM4aEVlj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #2340"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635",
"url": "https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c42e10c8a1ee_56973fe0e2ad45b46489ce--