IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move stream type into frame type (#1431)

Martin Thomson <notifications@github.com> Fri, 08 June 2018 13:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D740130EAF for <quic-issues@ietfa.amsl.com>; Fri, 8 Jun 2018 06:59:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ev_cCJaDkAZi for <quic-issues@ietfa.amsl.com>; Fri, 8 Jun 2018 06:58:58 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2E70E126CC7 for <quic-issues@ietf.org>; Fri, 8 Jun 2018 06:58:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=wm7tMdg5n29RTJWHj2kbDddVDHw=; b=ozoBfpxHUnC+3lqx 4EPcF7tx7YnAIRwVUE3IMQdTLwnMF8vrAGi6YMCjqfyNHe7jSIiq57IS3fSilFUP tKzs/wgj11vHrEAMNIOpPGj2QB54XlvcGZkrMhmjhofvkpYjoaiZJOWtvLym0Goc y8k/aDwDVCx0eJscKAiOzTUJmkE=
Received: by filter0113p1iad2.sendgrid.net with SMTP id filter0113p1iad2-13491-5B1A8BA1-F 2018-06-08 13:58:57.27820528 +0000 UTC
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id k7x4hILfQRiksE6fa72UBw for <quic-issues@ietf.org>; Fri, 08 Jun 2018 13:58:57.176 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id 28BA4C132B for <quic-issues@ietf.org>; Fri, 8 Jun 2018 06:58:57 -0700 (PDT)
Date: Fri, 08 Jun 2018 13:58:57 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba7357915dc7a6937b75f3733ba6d78912d1f837792cf0000000117324da192a169ce13b4e51c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1431/review/127172177@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1431@github.com>
References: <quicwg/base-drafts/pull/1431@github.com>
Subject: Re: [quicwg/base-drafts] Move stream type into frame type (#1431)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1a8ba126c0b_12a82ae01f73af588200"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0nOU8/kb7AnS3m50w+KDZw+vWXrEoNd4ZKY+ sz027L9RWqnjXLFcw/5aM6Wh50h7+XbhzKDbSC2n0Vy5XwOj78xkbs0y//N3vkTkaQFZz56nsqV+uk 618RDEftWMsT25ki8o+IzeCz61lcL5Kp9BViU3EpycCZN8qVA9vHoA9+VcwDSdzR4Wj8ryq+bWqPqt M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ifsb7k2cPQTsyL-dXx07yOFsCqg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 13:59:01 -0000

martinthomson commented on this pull request.

Funny.  @janaiyengar was a strong proponent of the current design and argued against this approach when I suggested it.  I was convinced by that argument, and remain so.

Creating 4 of each type is a little unwieldy.  Worse when you consider that a server can never send 0x13 and a client can never send 0x12.  It isn't any more complicated to implement, but it isn't without costs.

Mostly, it is the secondary things that matter here.  When you are debugging, you need extra information to distinguish between stream 2 and stream 2 and stream 2 and stream 2.  Talking about streams requires that you are more explicit.  Yeah, it fixes the problem where people say N+1 and mean N+4, but is it really that useful a change?

Also, it ruins suggestions I made regarding PRIORITY, but that's not that important :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1431#pullrequestreview-127172177

v2.28.0 | Report a Bug | By Email | System Status