Re: [quicwg/base-drafts] What needs to be checked for address validation (#3327)

ekr <notifications@github.com> Mon, 17 February 2020 17:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2732B1208DF for <quic-issues@ietfa.amsl.com>; Mon, 17 Feb 2020 09:45:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZP-hVWuwiymE for <quic-issues@ietfa.amsl.com>; Mon, 17 Feb 2020 09:45:15 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB1CB1208D8 for <quic-issues@ietf.org>; Mon, 17 Feb 2020 09:45:14 -0800 (PST)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id 30C4D2C0AEA for <quic-issues@ietf.org>; Mon, 17 Feb 2020 09:45:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581961511; bh=G/vzrOaB+R/Y0GlvyXMpcIXOkqcaPwTdGsb/8QWoBoI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JNlETB5dMbPVZZ4J9pyINneW5oEcE6IbgkDsRw37AY/3XQtiupl4JMITgEs1NJhsR UsXdvj2P994WIGCwhAtoTHvhJaKpdJQ+BZeEt4LE5Vp9data4qiJzNshaKvhf/TgDZ ETXB5aAAhNiQDqz1tKXRVBitmQ7BeI10bHdMHPM0=
Date: Mon, 17 Feb 2020 09:45:11 -0800
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2ET6PUZOVCI7EIP2N4LAB2PEVBNHHCBFKYSE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3327/review/359895222@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3327@github.com>
References: <quicwg/base-drafts/pull/3327@github.com>
Subject: Re: [quicwg/base-drafts] What needs to be checked for address validation (#3327)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4ad1272202b_51273f894bccd968489329"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/il3je66Z4HCY7sl5ZZupHiix5Hg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Feb 2020 17:45:24 -0000

ekr commented on this pull request.



> @@ -1834,9 +1834,18 @@ SHOULD include information that allows the server to verify that the source IP
 address and port in client packets remains constant.
 
 Servers might use tokens from NEW_TOKEN in deciding not to send a Retry packet,
-even if the client address has changed. Tokens sent in NEW_TOKEN frames SHOULD
-include information that allows the server to verify if the client address is
-stable, but might allow for different NAT bindings or ephemeral port selection.
+even if the client address has changed. Tokens sent in NEW_TOKEN frames MUST
+include information that allows the server to verify that the client IP address
+has not changed from when the token was issued.

I think this text would be a lot clearer if you moved the first sentence to the end and wrote it as:

"Servers might use tokens from NEW_TOKEN in deciding not to send a Retry packet,
even if the client address has changed. However, if the address has changed, the
server MUST adhere to the anti-amplification limits found in XXX"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3327#pullrequestreview-359895222