Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E6161130FEC for ; Fri, 6 Jul 2018 13:50:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -8.009 X-Spam-Level: X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GUxTynTrK-Sl for ; Fri, 6 Jul 2018 13:50:40 -0700 (PDT) Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3C11130F90 for ; Fri, 6 Jul 2018 13:50:38 -0700 (PDT) Date: Fri, 06 Jul 2018 13:50:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530910238; bh=6kxvJwUEvk1zKRxQh9d2BqZ3oRYQSgcOWYWjsEYSQO0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FaG13ClnzIndxH14pIxbgW/4Ewdg9jZ7zfaI8/ugPByeLE+vOt2r7VLNLGKKFRhxB orhX3pHOMpubNv7RUzJC6EB4aI5GXLE21wMVP1wrAZRmDuOGZBDdxtHOMf5x/JFDC7 tCNWVF5pX908B3Yzqrreyog+SOAZNx+PdQpHwDW4= From: janaiyengar Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Tolerate unknown stream types, add greasing (#1525) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5b3fd61e1917d_2ef7d3fc95858ef8870571"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: janaiyengar X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.26 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 20:50:50 -0000 ----==_mimepart_5b3fd61e1917d_2ef7d3fc95858ef8870571 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit janaiyengar commented on this pull request. A couple of comments > If the stream header indicates a stream type which is not supported by the -recipient, this SHOULD be treated as a stream error of type -HTTP_UNKNOWN_STREAM_TYPE. The semantics of the remainder of the stream are -unknown. Implementations SHOULD NOT send stream types the peer is not already -known to support, since a stream error can be promoted to a connection error at -the peer's discretion (see {{errors}}). +recipient, the remainder of the stream cannot be consumed as the semantics are +unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING +frame with an error code of HTTP_UNKNOWN_STREAM_TYPE, but MUST NOT consider such +streams to be an error of any kind. + +Implementations SHOULD NOT send stream types the peer is not already known to +support. Stream types which could modify the state or semantics of existing This text recommends (SHOULD NOT) negotiating supported stream types. Is this recommendation necessary? > @@ -1651,6 +1670,18 @@ The entries in the following table are registered by this document. | Push Stream | 0x50 | {{server-push}} | Server | | ---------------- | ------ | -------------------------- | ------ | +Additionally, each code of the format `0x1f * N` for values of N in the +range (0..8) (that is, `0x00`, `0x1f`, etc., through `0xf8`), the following Let's list them all; it's only 8 values. ('0x00', '0x1f', '0x3e', '0x5d', '0x7c', '0x9b', '0xba', '0xd9', '0xf8'). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1525#pullrequestreview-135150465 ----==_mimepart_5b3fd61e1917d_2ef7d3fc95858ef8870571 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@janaiyengar commented on this pull request.

A couple of comments

In draft-ietf-quic-http.md:

>  
 If the stream header indicates a stream type which is not supported by the
-recipient, this SHOULD be treated as a stream error of type
-HTTP_UNKNOWN_STREAM_TYPE.  The semantics of the remainder of the stream are
-unknown. Implementations SHOULD NOT send stream types the peer is not already
-known to support, since a stream error can be promoted to a connection error at
-the peer's discretion (see {{errors}}).
+recipient, the remainder of the stream cannot be consumed as the semantics are
+unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING
+frame with an error code of HTTP_UNKNOWN_STREAM_TYPE, but MUST NOT consider such
+streams to be an error of any kind.
+
+Implementations SHOULD NOT send stream types the peer is not already known to
+support.   Stream types which could modify the state or semantics of existing

This text recommends (SHOULD NOT) negotiating supported stream types. Is this recommendation necessary?

In draft-ietf-quic-http.md:

> @@ -1651,6 +1670,18 @@ The entries in the following table are registered by this document.
 | Push Stream      | 0x50   | {{server-push}}            | Server |
 | ---------------- | ------ | -------------------------- | ------ |
 
+Additionally, each code of the format `0x1f * N` for values of N in the
+range (0..8) (that is, `0x00`, `0x1f`, etc., through `0xf8`), the following

Let's list them all; it's only 8 values. ('0x00', '0x1f', '0x3e', '0x5d', '0x7c', '0x9b', '0xba', '0xd9', '0xf8').

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5b3fd61e1917d_2ef7d3fc95858ef8870571--