IETF Logo Mail Archive

Re: [quicwg/base-drafts] Change packet types (#1655)

Udip Pant <notifications@github.com> Mon, 17 September 2018 14:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 58056130E04 for <quic-issues@ietfa.amsl.com>; Mon, 17 Sep 2018 07:04:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.509
X-Spam-Level:
X-Spam-Status: No, score=-7.509 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GB_ABOUTYOU=0.5, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IfFo9_ZY1zSN for <quic-issues@ietfa.amsl.com>; Mon, 17 Sep 2018 07:04:25 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F2630130DC2 for <quic-issues@ietf.org>; Mon, 17 Sep 2018 07:04:24 -0700 (PDT)
Date: Mon, 17 Sep 2018 07:04:23 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537193063; bh=Quz8DtHXcxpl1M57kZSY6BvqPgr2gnGd4p/wujnINRU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Cxd7gkBN5k4V/fjmSJd4jw26oVIyh29RmzXj5pQLZ6Jq8n7k57zcyOkoreiTLrMBU pnqpSdrUZrfFUaZxatbujYYhhzPXG+K2jMIABMMCG6iW81i01L03Th6reYKTUNFbg+ VSS8qkB+O5nABWzoyrPYoOPny9e8v/ojAVbDfxng=
From: Udip Pant <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4d04183f93746af278bc1b8e08ede0ccad2df5b892cf0000000117b7766792a169ce14ddfaae@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1655/422029800@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1655@github.com>
References: <quicwg/base-drafts/issues/1655@github.com>
Subject: Re: [quicwg/base-drafts] Change packet types (#1655)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b9fb467cfb65_32f63fb77bad45b82723bf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: udippant
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iwfl2M92RCXXJUPh7ZkzZo7LlK4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 14:04:26 -0000

(pkt_type & 0xc0 != 0x80) should be fine. But curious about your type grouping that results in this (with first MSB for long header, you'd still just be using the second MSB here).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1655#issuecomment-422029800

v2.46.0 | Report a Bug | By Email | System Status