Re: [quicwg/base-drafts] One close frames (#1900)

ianswett <notifications@github.com> Wed, 24 October 2018 13:06 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C1CD0124408 for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 06:06:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.066
X-Spam-Level:
X-Spam-Status: No, score=-2.066 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qf6JYvUg38Yy for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 06:06:54 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4763912D4EF for <quic-issues@ietf.org>; Wed, 24 Oct 2018 06:06:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=M0VbkpuOkmch/llt540bZjxP7xs=; b=j05GZi3m/TXLcT4i qDEN74sixE+MX7zoaOxqEynRt6UpyAcYBhbmReMJM/n1BQ7i5wVdZ3sf+yCTRixz TuDNKDEY11tvLJJW7DpXRC4WZY3FTQamXr/6nc6JZCejKNdbq1kPMAlqCUHKaVvc n47Wn3Cwrk3/HMRfy8TW6+FadXo=
Received: by filter0313p1iad2.sendgrid.net with SMTP id filter0313p1iad2-16657-5BD06E6D-5 2018-10-24 13:06:53.061611445 +0000 UTC m=+4357.627539195
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0007p1iad2.sendgrid.net (SG) with ESMTP id 7F63iAsoRKuy4gJucRCABQ for <quic-issues@ietf.org>; Wed, 24 Oct 2018 13:06:53.067 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id 0BA0E260A26 for <quic-issues@ietf.org>; Wed, 24 Oct 2018 06:06:53 -0700 (PDT)
Date: Wed, 24 Oct 2018 13:06:53 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5d69675b12a7aab1f4486d637315c9ed062277bd92cf0000000117e8306d92a169ce164012de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1900/review/167895816@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1900@github.com>
References: <quicwg/base-drafts/pull/1900@github.com>
Subject: Re: [quicwg/base-drafts] One close frames (#1900)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd06e6da264_73ae3fa3a04d45bc725511"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3HW3LQ+LLAGXALr/mrnjxId+8Zc66HrDCXBa 5fxsiNZD4n/l8b5Udi3a2SIuIA29gi9Pe0GxmA8H9QyRN6TmJHOGEE0TLF6GE7QuULA7wOv5kw0Kjs uYu0EnFWLcKfqPo7K96qtb6XZkUWtFlTTpAsdsxYBpQCDSsBZey5g2/Baw==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/j-tiMbNj02j4FujamVPm393QcGY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 13:06:56 -0000

ianswett commented on this pull request.

I think this looks good, but I'm curious to see others feedback.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1900#pullrequestreview-167895816