[quicwg/base-drafts] Byte order of IP addresses in PreferredAddress (#2951)

Masakazu Kitajo <notifications@github.com> Fri, 02 August 2019 07:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 739F2120140 for <quic-issues@ietfa.amsl.com>; Fri, 2 Aug 2019 00:42:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PuVQQsihrr5q for <quic-issues@ietfa.amsl.com>; Fri, 2 Aug 2019 00:42:48 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9415120136 for <quic-issues@ietf.org>; Fri, 2 Aug 2019 00:42:48 -0700 (PDT)
Date: Fri, 02 Aug 2019 00:42:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1564731767; bh=1EHc7NFpfhWlLkhbUGdwtuGpWBcYuGzwl0xag0l9qAQ=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=zY4KwK6OIUNfKLl1tueO0+hF2ILjBL2csB2s+v+tNtx4pL129SYf8LtKWJCPC/f9m hZblKWLLkkYDO1tL3XeP4ikxr49VBVM/2zFEKTtmLwZA9DRwzEasocV/1Yu7gHcbM2 xSFIBXJ+wFL2kW29IDKUsKRsFe/k+Xxz7/Sggyww=
From: Masakazu Kitajo <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4O7S255GBX26FEGJF3KEN7PEVBNHHBYX6XRE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2951@github.com>
Subject: [quicwg/base-drafts] Byte order of IP addresses in PreferredAddress (#2951)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d43e977c502e_54373f85f6ecd964736d2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: maskit
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jCBP8f7YxoCjnykRU_plVA2yYuo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Aug 2019 07:42:50 -0000

Byte order of IP addresses in PreferredAddress is not explicitly stated. In practice, most OSs keep them in network byte order, and the spec says integers are in network byte order, however the fields for ip addresses are defined as opaque data. The byte order should be stated on this spec.

```
    struct {
     opaque ipv4Address[4];
     uint16 ipv4Port;
     opaque ipv6Address[16];
     uint16 ipv6Port;
     opaque connectionId<0..20>;
     opaque statelessResetToken[16];
   } PreferredAddress;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2951