Date: Wed, 22 May 2019 08:10:23 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3AWDWSR3RNHBG5LXV26KMN7EVBNHHBVHINUM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2733/review/240698898@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2733@github.com>
References: <quicwg/base-drafts/pull/2733@github.com>
Subject: Re: [quicwg/base-drafts] Allow reuse of stateless reset tokens (#2733)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ce5665f6acb8_746a3f862e4cd96826073a0";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jCyP__X7cv2-b0ysoUS4w2tQad8>


----==_mimepart_5ce5665f6acb8_746a3f862e4cd96826073a0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> @@ -2476,6 +2476,14 @@ the same static key (see {{reset-oracle}}).  A connection ID from a connection
 that is reset by revealing the Stateless Reset Token MUST NOT be reused for new
 connections at nodes that share a static key.
 
+The same Stateless Reset Token MAY be used for multiple connection IDs on the
+same connection.  An endpoint that reuses a Stateless Reset Token MUST ensure
+that any connection ID used on the connection is matched to the active
+connection, including any routing performed at load balancers, even when a
+connection ID has been retired.  Otherwise, an attacker might be able to send a
+packet with a retired connection ID and cause the endpoint to produce a
+Stateless Reset.
+
 Note that Stateless Reset packets do not have any cryptographic protection.

I've tweaked the text (there was a grammatical error), but I think that this was related to the change.  It was a minor editorial thing.  It's really hard to get this right.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2733#discussion_r286542720
----==_mimepart_5ce5665f6acb8_746a3f862e4cd96826073a0
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2733#discussion_r286542720">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -2476,6 +2476,14 @@ the same static key (see {{reset-oracle}}).  A connection ID from a connection
 that is reset by revealing the Stateless Reset Token MUST NOT be reused for new
 connections at nodes that share a static key.
 
+The same Stateless Reset Token MAY be used for multiple connection IDs on the
+same connection.  An endpoint that reuses a Stateless Reset Token MUST ensure
+that any connection ID used on the connection is matched to the active
+connection, including any routing performed at load balancers, even when a
+connection ID has been retired.  Otherwise, an attacker might be able to send a
+packet with a retired connection ID and cause the endpoint to produce a
+Stateless Reset.
+
 Note that Stateless Reset packets do not have any cryptographic protection.
</pre>
<p>I've tweaked the text (there was a grammatical error), but I think that this was related to the change.  It was a minor editorial thing.  It's really hard to get this right.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2733?email_source=notifications&amp;email_token=AFTOJK4JDATZYSCLTNCQOYTPWVO57A5CNFSM4HOI3TTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMMMEQ#discussion_r286542720">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2XQB7Y2S7TI3OOYSDPWVO57ANCNFSM4HOI3TTA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJKZ3CO45UYFP6XUAUS3PWVO57A5CNFSM4HOI3TTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMMMEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2733?email_source=notifications\u0026email_token=AFTOJK4JDATZYSCLTNCQOYTPWVO57A5CNFSM4HOI3TTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMMMEQ#discussion_r286542720",
"url": "https://github.com/quicwg/base-drafts/pull/2733?email_source=notifications\u0026email_token=AFTOJK4JDATZYSCLTNCQOYTPWVO57A5CNFSM4HOI3TTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMMMEQ#discussion_r286542720",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ce5665f6acb8_746a3f862e4cd96826073a0--