IETF Logo Mail Archive

Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

ianswett <notifications@github.com> Fri, 11 October 2019 00:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A5FFA1200C1 for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 17:27:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k3shHexpkeXN for <quic-issues@ietfa.amsl.com>; Thu, 10 Oct 2019 17:27:08 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD44312003E for <quic-issues@ietf.org>; Thu, 10 Oct 2019 17:27:07 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id DD57A6E12D6 for <quic-issues@ietf.org>; Thu, 10 Oct 2019 17:27:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570753626; bh=5mqYFB4etTUvPICVehkM/lYzaE+Y+DzMN1uuwo42fi0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MPMcyYRebXVGXRUzq6eSyOTKy+ObMMVaJR9fO8LbG0iDj+P/3MXkB6Qf1AdKo+fnS DB7AUUYl11HHtrMFWjwf5RkCnWroJscSql47twfxmQUcS7UW5tiX9rBhMTt6b6mCeP Jch/nUclsIpUGMtzgSV4kzed85uAtw/EBgZwwLzs=
Date: Thu, 10 Oct 2019 17:27:06 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK35VBBDJOSUFQA7UIF3VUGOVEVBNHHB4DMTGA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3083/review/300417977@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3083@github.com>
References: <quicwg/base-drafts/pull/3083@github.com>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9fcc5acf50a_57893fe6610cd96011147b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jDvnUXpIAqWjFC1VGWoBv2N6hak>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2019 00:27:10 -0000

ianswett commented on this pull request.



> @@ -1071,7 +1071,8 @@ When a server receives this frame, it aborts sending the response for the
 identified server push.  If the server has not yet started to send the server

How about reorganizing this section with one paragraph like this that starts with "When a server receives this frame, ..." and have another with "When a client receives this frame, ..." since the roles are completely asymmetric I believe?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3083#pullrequestreview-300417977

v2.23.0 | Report a Bug | By Email