Re: [quicwg/base-drafts] Clarify bytes_in_flight (#551)

mirjak <notifications@github.com> Thu, 25 May 2017 16:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF806129B4B for <quic-issues@ietfa.amsl.com>; Thu, 25 May 2017 09:53:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.396
X-Spam-Level:
X-Spam-Status: No, score=-8.396 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wFvylqM9Rqdn for <quic-issues@ietfa.amsl.com>; Thu, 25 May 2017 09:53:29 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext4.iad.github.net [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B1DF1293E8 for <quic-issues@ietf.org>; Thu, 25 May 2017 09:53:29 -0700 (PDT)
Date: Thu, 25 May 2017 09:53:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1495731208; bh=HmUa6nFeMP6TwBtgfpKytJlt7xeteWiTig0tKhhdUd4=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=l3gXsocsXViCdm/KXIc/eOEV/0qAb6FEqr11QCKbkpLadu8YZH0vWallP9ChiANzV T/BlBAO71lw1sM0mD0swlpkwJFzh40jPa1voKnJnppKyn9RTwUWU3o+UwG8abnwgqA RjFb7WM3GGmlTU8h4RpFyIqHF3cB2GBHILu11Dfo=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab14ce6ec2eb33570d30b64f2d0451b6eea73ccc3f92cf00000001153ece0892a169ce0dbd3499@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/551/review/40331916@github.com>
In-Reply-To: <quicwg/base-drafts/pull/551@github.com>
References: <quicwg/base-drafts/pull/551@github.com>
Subject: Re: [quicwg/base-drafts] Clarify bytes_in_flight (#551)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59270c083fb59_45e73fe4bc811c2c88925"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jEisoRLc5lMwugmIRI-eI-RW_Sg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2017 16:53:31 -0000

mirjak commented on this pull request.



> @@ -615,6 +615,8 @@ are described in this section.
 bytes_in_flight:
 : The sum of the size in bytes of all sent packets that contain at least
   one retransmittable frame, and have not been acked or declared lost.
+  The size does not include IP or UDP overhead.  Ack only frames do not
+  count towards byte_in_flight.

Isn't this basically the same question as the question which packets should be congestion controlled? All bytes that are congestion controlled should be counted for bytes_in_flight, no?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/551#discussion_r118530298