IETF Logo Mail Archive

Re: [quicwg/base-drafts] GOAWAY means no more (#3338)

Lucas Pardue <notifications@github.com> Wed, 15 January 2020 01:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67F9D120058 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:30:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HtAFwJBdeQmE for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:30:00 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD9FD120041 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:30:00 -0800 (PST)
Received: from github-lowworker-3a0df0f.ac4-iad.github.net (github-lowworker-3a0df0f.ac4-iad.github.net [10.52.25.92]) by smtp.github.com (Postfix) with ESMTP id 5248A2615AC for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:30:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579051800; bh=YP2w0rQU0aZGprokQj6lXjFycEUdKBdQz4K65aGLAl8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0xa5k4rz2+t8Xozdoh2ToERR5Fajg30p8XcTlYoIwuYfLJoikVcTDjfRcJ6NdIH1O 8e8Xr4LiqC8cR9LYwMMSimhmsI0/9M1h0X8CKDxNemLJpZXjD3vWYOYJ6AVTQGjjSW 26HzwiYPwPRAJy1SWFD7sDZIEirbU71qG5aIVT8c=
Date: Tue, 14 Jan 2020 17:30:00 -0800
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7KULTFGIC6UYCNIF54FOOZREVBNHHCBPAYFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3338/review/342943499@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3338@github.com>
References: <quicwg/base-drafts/pull/3338@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY means no more (#3338)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1e6b1894ed_32693fc8d1acd968116926"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jJJzDNIrKuKgxoQB397TMdNPFAQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 01:30:02 -0000

LPardue commented on this pull request.



> +Before closing the connection, a GOAWAY frame MAY be sent to allow the client to
+retry some requests.  Including the GOAWAY frame in the same packet as the QUIC
 CONNECTION_CLOSE frame improves the chances of the frame being received by
 clients.

We're mixing together processing of a QUIC frame and an application-layer frame delivered inside of STREAM frames. I'm not sure trying to make assertions on the ordering of those things is the best way to do it. My I should open this out as a separate issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3338#discussion_r366657847

v2.13.0 | Report a Bug | By Email