IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add a section on flow control performance (#3793)

Martin Thomson <notifications@github.com> Fri, 10 July 2020 00:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F6B63A0A14 for <quic-issues@ietfa.amsl.com>; Thu, 9 Jul 2020 17:21:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q90jSmiyVQL6 for <quic-issues@ietfa.amsl.com>; Thu, 9 Jul 2020 17:21:06 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 06A0E3A0A0E for <quic-issues@ietf.org>; Thu, 9 Jul 2020 17:21:06 -0700 (PDT)
Received: from github-lowworker-9d2806a.ash1-iad.github.net (github-lowworker-9d2806a.ash1-iad.github.net [10.56.102.50]) by smtp.github.com (Postfix) with ESMTP id 52F02E0A7E for <quic-issues@ietf.org>; Thu, 9 Jul 2020 17:21:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594340465; bh=U4iaB7Jc92DMEJ87m9nZcDpJuXAyosnEeTM9g6REu9I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=j2wglW28C9K7XL9gdzjWjtkCA9nD4cJd8IddAUyte5IaJ9dWkEentTbZNOGtc2/gW W+nWsQwY5Us7mQ7Cq+tob1PlnrSrq1UK1b6MrzTAN6fGE/UHTob05vrSCnjdnBGMDP Wfic8yBkb1JXMt3r1aNMGleplR6P6mFVAOTAUDpA=
Date: Thu, 09 Jul 2020 17:21:05 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK777WT575FSOZ73MHF5COKXDEVBNHHCNAR3C4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3793/review/446049144@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3793@github.com>
References: <quicwg/base-drafts/pull/3793@github.com>
Subject: Re: [quicwg/base-drafts] Add a section on flow control performance (#3793)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f07b47143722_7d693fc1cd2cd96c304097"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jKKXNvxzR4rgzgdzK1avkIMHf4A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2020 00:21:07 -0000

@martinthomson commented on this pull request.



> +updates to flow control limits can improve performance. However, an excessive
+rate of updates can also adversely affect performance.

Should we instead say "Sending of packets just to provide flow control updates can increase network load and adversely affect performance.  Sending flow control updates along with other frames, such as ACK frames, can reduce the cost of those updates."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3793#discussion_r452558379

v2.27.6 | Report a Bug | By Email | System Status