Re: [quicwg/base-drafts] Minor fixes for the recovery draft (#3813)

Kazu Yamamoto <notifications@github.com> Mon, 06 July 2020 03:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E2833A0E6C for <quic-issues@ietfa.amsl.com>; Sun, 5 Jul 2020 20:38:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pj9IP8rTaiHL for <quic-issues@ietfa.amsl.com>; Sun, 5 Jul 2020 20:38:40 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90DA03A0E6B for <quic-issues@ietf.org>; Sun, 5 Jul 2020 20:38:40 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id 95AF66A0854 for <quic-issues@ietf.org>; Sun, 5 Jul 2020 20:38:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594006719; bh=htLISojY670oWF9IG3T3Uk1kSbQ8dKoOFsKLNAi539A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y5FczOguzN0RJpx7c6GwqflnjGsrv5xWQdIVBmNs3y6G/GTauiXdLM33JhabRyX0M cO0kveLDQBQdoxpD2RLgvJDU7BhtCCDvwqlRGH9ej5CW/MlAN2cpzeV7/1S/7WGE0j INNb065VpFXKuWkufgMzugS9GEW61bvde7TE7A1c=
Date: Sun, 05 Jul 2020 20:38:39 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2HUHYQ6XGZGFAAINV5BZ637EVBNHHCNOGIUE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3813/653998174@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3813@github.com>
References: <quicwg/base-drafts/issues/3813@github.com>
Subject: Re: [quicwg/base-drafts] Minor fixes for the recovery draft (#3813)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f029cbf857cb_2b223fae4dccd9642332de"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jKtICibXyjUSwUyzAwrim3NntGc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2020 03:38:43 -0000

The `return` in `for` in `GetPtoTimeAndSpace` suggests me that the semantics of `return` in `for` returns a value form the function. In `OnPacketsAcked`, `return` is also used in `for`. But in this case, it seems to me that the semantics of this `return` goes to the next item.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3813#issuecomment-653998174