Re: [quicwg/base-drafts] quic-tls nits (#2445)

Martin Thomson <> Mon, 11 February 2019 00:19 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id D04B812958B for <>; Sun, 10 Feb 2019 16:19:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id MErORgRqTzzy for <>; Sun, 10 Feb 2019 16:19:01 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id CC939129284 for <>; Sun, 10 Feb 2019 16:19:00 -0800 (PST)
Date: Sun, 10 Feb 2019 16:18:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1549844339; bh=uT6FNnobbvBZozgCWF5xfpluki0P3HLbA4FsTlC1g4U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dk0fxOvC2zk3jHGE9ymAHEo1ygDUooN4PsltBLJ0ErwQ+ZOCvn0M26BKomoK1L4o3 M3q1nmrwuMWeEWII8MJP2CYiZYGMqwqmnCADCpRaYOQjWrf/K69z9uSdIzhrKgQUDL DLjqfxTN84OcTPKptVGPYb9Bx6AQyarbW3s2lovU=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2445/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] quic-tls nits (#2445)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c60bf73e68e5_47353fa2800d45b4741447"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 11 Feb 2019 00:19:03 -0000

martinthomson approved this pull request.

LGTM, with the one change altered.

> @@ -788,7 +788,7 @@ The value of initial_salt is a 20 byte sequence shown in the figure in
 hexadecimal notation. Future versions of QUIC SHOULD generate a new salt value,
 thus ensuring that the keys are different for each version of QUIC. This
 prevents a middlebox that only recognizes one version of QUIC from seeing or
-modifying the contents of handshake packets from future versions.
+modifying the contents of Initial packets from future versions.

@marten-seemann's point is right.  The intent here is to use a generic statement (packets that are part of the handshake process), as opposed to identifying a specific packet type in this version.

modifying the contents of packets from future versions.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: