IETF Logo Mail Archive

Re: [quicwg/base-drafts] quic-tls nits (#2445)

Martin Thomson <notifications@github.com> Mon, 11 February 2019 00:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D04B812958B for <quic-issues@ietfa.amsl.com>; Sun, 10 Feb 2019 16:19:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MErORgRqTzzy for <quic-issues@ietfa.amsl.com>; Sun, 10 Feb 2019 16:19:01 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC939129284 for <quic-issues@ietf.org>; Sun, 10 Feb 2019 16:19:00 -0800 (PST)
Date: Sun, 10 Feb 2019 16:18:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549844339; bh=uT6FNnobbvBZozgCWF5xfpluki0P3HLbA4FsTlC1g4U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dk0fxOvC2zk3jHGE9ymAHEo1ygDUooN4PsltBLJ0ErwQ+ZOCvn0M26BKomoK1L4o3 M3q1nmrwuMWeEWII8MJP2CYiZYGMqwqmnCADCpRaYOQjWrf/K69z9uSdIzhrKgQUDL DLjqfxTN84OcTPKptVGPYb9Bx6AQyarbW3s2lovU=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abce27d899bb18216c97cd096f4663e26de06474d792cf000000011878817392a169ce1857741f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2445/review/201931440@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2445@github.com>
References: <quicwg/base-drafts/pull/2445@github.com>
Subject: Re: [quicwg/base-drafts] quic-tls nits (#2445)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c60bf73e68e5_47353fa2800d45b4741447"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jLg-rk8rMn_AFUgw3z7Imki-7s4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 00:19:03 -0000

martinthomson approved this pull request.

LGTM, with the one change altered.

> @@ -788,7 +788,7 @@ The value of initial_salt is a 20 byte sequence shown in the figure in
 hexadecimal notation. Future versions of QUIC SHOULD generate a new salt value,
 thus ensuring that the keys are different for each version of QUIC. This
 prevents a middlebox that only recognizes one version of QUIC from seeing or
-modifying the contents of handshake packets from future versions.
+modifying the contents of Initial packets from future versions.

@marten-seemann's point is right.  The intent here is to use a generic statement (packets that are part of the handshake process), as opposed to identifying a specific packet type in this version.

```suggestion
modifying the contents of packets from future versions.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2445#pullrequestreview-201931440

v2.23.0 | Report a Bug | By Email