Re: [quicwg/base-drafts] Clarify RTT calculations in recovery (#2506)

Jana Iyengar <notifications@github.com> Sat, 30 March 2019 20:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B726812026D for <quic-issues@ietfa.amsl.com>; Sat, 30 Mar 2019 13:03:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OiEriIVftBBl for <quic-issues@ietfa.amsl.com>; Sat, 30 Mar 2019 13:03:28 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EFD9B120269 for <quic-issues@ietf.org>; Sat, 30 Mar 2019 13:03:27 -0700 (PDT)
Date: Sat, 30 Mar 2019 13:03:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553976206; bh=ht3nMA9NRgGworsMIVmB1g163a3VEqWgcf9jh9NSBds=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ycwDdgN+LavpwUwbLUk5dmEEivhoIKBmYe93X0YcK/R00k3GwHUjDgWV8wGzLM27s pqAeC6aeL/vUdVqK4tBWzUKv89ta2AFNmmE04j+OnVHBfiD6KBw4O3bxhLbCn3eyih 1VHI4ZQUyr515e6zgI2PiZB4/r8VItsHDL7sIXKs=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab599452c6a881fc72b60b7d40ee731499b9989b0e92cf0000000118b78d8e92a169ce18f867ef@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2506/review/220835554@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2506@github.com>
References: <quicwg/base-drafts/pull/2506@github.com>
Subject: Re: [quicwg/base-drafts] Clarify RTT calculations in recovery (#2506)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c9fcb8e71bdc_33a03ff1f52d45c08309fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jNB-FDPtFJqwXnP4X_EOOQ1Ir5E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2019 20:03:30 -0000

janaiyengar approved this pull request.

Small fix, but I'll file a new editorial issue with martin's restructure comment, and let's merge this.

> @@ -330,6 +330,31 @@ min_rtt is the minimum RTT measured over the connection, prior to adjusting by
 ack delay.  Ignoring ack delay for min RTT prevents intentional or unintentional
 underestimation of min RTT, which in turn prevents underestimating smoothed RTT.
 
+A sender calculates both smoothed RTT (SRTT) and RTT variance (RTTVAR) similar
+to those specified in {{?RFC6298}}, see {{on-ack-received}}.
+
+On every newly acknowledged ack-eliciting largest acked:
+~~~
+latest_rtt = ack_time - send_time_of_largest_acked
+~~~
+
+First RTT sample:
+~~~
+min_rtt = latest_rtt
+smoothed_rtt = latest_rtt

For the first sample, using ack_delay will reduce the smoothed_rtt to below min_rtt. I think adding a sentence up in the para above might make sense. How about "Note that smoothed_rtt computation on the first RTT sample does not use ack_delay, because doing so will lead to a smoothed_rtt that is smaller than the min_rtt."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2506#pullrequestreview-220835554