Re: [quicwg/base-drafts] Fix bug in Insert Count Increment description. (#3132)
Bence Béky <notifications@github.com> Wed, 30 October 2019 15:55 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B99A120019 for <quic-issues@ietfa.amsl.com>; Wed, 30 Oct 2019 08:55:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R56R2pQcwqan for <quic-issues@ietfa.amsl.com>; Wed, 30 Oct 2019 08:55:51 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1880B12083F for <quic-issues@ietf.org>; Wed, 30 Oct 2019 08:55:51 -0700 (PDT)
Date: Wed, 30 Oct 2019 08:55:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572450950; bh=B0qIMcfAUg+jkBhTYDYhaEN5VUeLs8Bh7JxzbTRFelg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gVnIY2seHovINhALNlTSU2UIH2jrEmA8edZ/c6bX54NNOGwrlI2+hno16IEdYF1vF EE4UWeS1lzxr3g3QVbyOifYkqyJJvtH28mTu05lV9EQUgKIE3eg3CvNFhcVCjYIKGN CrKCkEhYqJFJax5zqDqpeGKLZS4MNUV8hWmjDYIQ=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4E3B6DRKKZNGKXID53Y3ZRNEVBNHHB45IKMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3132/review/309320281@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3132@github.com>
References: <quicwg/base-drafts/pull/3132@github.com>
Subject: Re: [quicwg/base-drafts] Fix bug in Insert Count Increment description. (#3132)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db9b286393f5_715b3fcc8f6cd964117527"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jTbFOnna5_uSiAcMVtRQ5Ftnk-Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2019 15:55:52 -0000
bencebeky commented on this pull request. > -If a header block was potentially blocking, the encoder infers from receiving a -Header Acknowledgement instruction ({{header-acknowledgement}}) that the decoder -has received all dynamic table state necessary to process that header block. If -the Required Insert Count of the acknowledged header block is greater than the -current Known Received Count, the encoder updates the Known Received Count to -the value of the Required Insert Count of the acknowledged header block. +The Known Received Count is the total number of acknowledged dynamic table +insertions and duplications. It is updated using Header Acknowledgement That's a good point. I'm reverting most of this paragraph. Sorry for the churn. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3132#discussion_r340705108
- [quicwg/base-drafts] Fix bug in Insert Count Incr… Bence Béky
- Re: [quicwg/base-drafts] Fix bug in Insert Count … Mike Bishop
- Re: [quicwg/base-drafts] Fix bug in Insert Count … afrind
- Re: [quicwg/base-drafts] Fix bug in Insert Count … Bence Béky
- Re: [quicwg/base-drafts] Fix bug in Insert Count … Bence Béky
- Re: [quicwg/base-drafts] Fix bug in Insert Count … Bence Béky
- Re: [quicwg/base-drafts] Fix bug in Insert Count … afrind