Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)
janaiyengar <notifications@github.com> Thu, 29 November 2018 03:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9023F126C7E for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 19:39:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4a__sa3Z0pD8 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 19:39:37 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB3F4130DFD for <quic-issues@ietf.org>; Wed, 28 Nov 2018 19:39:36 -0800 (PST)
Date: Wed, 28 Nov 2018 19:39:35 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543462775; bh=w4jJhv56hdqNlqMXNxs3DwVawrIEfqFVfwqq3K42ecQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kuvG31lFgdWhSkq54ZYR+RLVz79yt8d3EielatA7YVvYTy0qrhmQaUEN5D/mw6G8b FoJK1hy7ivN75zN8Ttj9VFjmENPzMKzKBgEviRbLChp5ldR2zNhrViKvWmGyXH9Qd+ RyMVShL/y2FXgdL6U9NkV8vXjcm7ujC3pju206TA=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab28727d6249df5997194e25cb36a6c8cb6da6327d92cf000000011817217792a169ce16f4226e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2060/442695216@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2060@github.com>
References: <quicwg/base-drafts/issues/2060@github.com>
Subject: Re: [quicwg/base-drafts] compensation of ack_delay is fragile against errors (#2060)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bff5f77cc207_1c973f95d14d45bc100296"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/j_RsUwG7px78z-l95TqWyDBXv6Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2018 03:39:39 -0000
@kazuho @martinthomson : Mathematically, yes, but I wanted to protect against overflow. @kazuho: I'm concerned that if the ack_delay being reported is too large, I don't know how much of that is in error and how much of that is accurate. The patch assumes that exactly latest_rtt - min_rtt is the correct ack_delay, but there's no evidence of it. The problem with the proposed patch is that a client that reports an ack_delay that is too large will automatically cause the sender to always believe that the RTT is not growing at all. (Imagine the case where ack_delay is always reported as MAX_INT. This means that the sender will always end up with latest_rtt = min_rtt.) I'm suggesting that if there's an indication that the peer is feeding in values that are too large for ack_delay (which should not happen consistently or all the time), then we should ignore ack_delay. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2060#issuecomment-442695216
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- [quicwg/base-drafts] compensation of ack_delay is… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Martin Thomson
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… Dmitri Tikhonov
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… janaiyengar
- Re: [quicwg/base-drafts] compensation of ack_dela… Kazuho Oku
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett
- Re: [quicwg/base-drafts] compensation of ack_dela… ianswett