Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 0095A120172
 for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 12:25:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.463
X-Spam-Level: 
X-Spam-Status: No, score=-1.463 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001,
 MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01,
 URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id y7UOuvsIbhNM for <quic-issues@ietfa.amsl.com>;
 Fri, 10 May 2019 12:25:38 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 1360E12011E
 for <quic-issues@ietf.org>; Fri, 10 May 2019 12:25:38 -0700 (PDT)
Date: Fri, 10 May 2019 12:25:36 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1557516336;
 bh=o1yNJ9IVp+NmrLl9EgwDunwa8ltrgyfwJEDlFsnsWHw=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=A3KAhcWo+wQcq1UkQpJkPzmKz1yAq9VjxgTe6LIy9DfjRDxv4ExKTN9//la4GdQLA
 V3+vCGAXt0xaefZOlgr1bgVsO9lo9x42wgKvFpG8vlj1Ima2nh52vKapdkhYqx7Q1W
 mK+pyeVkEQe2FP9TOf10xmy8cXoOyR15XV4q0ylE=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3QMOF66XE32Y5QGO524MBLBEVBNHHBUXBX44@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2680/review/236275166@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2680@github.com>
References: <quicwg/base-drafts/pull/2680@github.com>
Subject: Re: [quicwg/base-drafts] Change error codes from 16-bit to varints
 (#2680)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5cd5d030c6c93_c423fc1258cd9642520d9";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jfylM6mvH6tpkaSHkQiYxxeIpu0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 May 2019 19:25:40 -0000


----==_mimepart_5cd5d030c6c93_c423fc1258cd9642520d9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



>  
 Registrations MUST include the following fields:
 
 Value:
 
 : The numeric value of the assignment (registrations will be between 0x0000 and
-  0xfeff).
+  0x3fff).

I took this from adjacent text "QUIC Frame Type Registry": https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-22.2

I'm honestly now sure what the correct value is, but I think we should be consistent?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2680#discussion_r283014079
----==_mimepart_5cd5d030c6c93_c423fc1258cd9642520d9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2680#discussion_r283014079">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  
 Registrations MUST include the following fields:
 
 Value:
 
 : The numeric value of the assignment (registrations will be between 0x0000 and
-  0xfeff).
+  0x3fff).
</pre>
<p>I took this from adjacent text "QUIC Frame Type Registry": <a href="https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-22.2" rel="nofollow">https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-22.2</a></p>
<p>I'm honestly now sure what the correct value is, but I think we should be consistent?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2680#discussion_r283014079">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK54NKKBGJDGC423FDDPUXD3BANCNFSM4HL2YBZQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK4YSMFOXOOYMYYMW5TPUXD3BA5CNFSM4HL2YBZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYKULXQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2680#discussion_r283014079",
"url": "https://github.com/quicwg/base-drafts/pull/2680#discussion_r283014079",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5cd5d030c6c93_c423fc1258cd9642520d9--

