Re: [quicwg/base-drafts] fix pseudocode for TLP alarm duration (#1225)
ianswett <notifications@github.com> Sun, 18 March 2018 12:21 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B7A5128896 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 05:21:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.392
X-Spam-Level:
X-Spam-Status: No, score=-5.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qb4ZQsbA0t8I for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 05:21:45 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99C4F127873 for <quic-issues@ietf.org>; Sun, 18 Mar 2018 05:21:45 -0700 (PDT)
Date: Sun, 18 Mar 2018 05:21:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521375705; bh=ln/ak/sST4kBXq2woFztgTTbSIrn+LoZcTU4zTlFmu0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CY6xJFIYNGaP2ZnTQDZ9nvSOrM01mVg4QXQArWYTyDA4Zc46piHcN3fU8lx3DaAVy pN1a/62fOsn4416KzfT8ZbZIp9QKhamZEgcQXVUiVED4s5UwmV50hxOTbAfHQcdGVO px7ruxbZ+eF5RAHYi8BGVUzPOQQhYlZjGh/ZHX8M=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab631430d1643262df076128bf34a0696140fb07ab92cf0000000116c61bd992a169ce1240b28e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1225/review/104795226@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1225@github.com>
References: <quicwg/base-drafts/pull/1225@github.com>
Subject: Re: [quicwg/base-drafts] fix pseudocode for TLP alarm duration (#1225)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae59d99d25_75023fe9a7cd8f2c35811c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jgcaUUduL3nLHqacim6Km2Mc5SA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 12:21:48 -0000
ianswett approved this pull request. One nit, but looks correct to me. > else: - // RTO alarm + // RTO or TLP alarm + // calculate RTO duration Calculate -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1225#pullrequestreview-104795226
- [quicwg/base-drafts] fix pseudocode for TLP alarm… Marten Seemann
- Re: [quicwg/base-drafts] fix pseudocode for TLP a… ianswett
- Re: [quicwg/base-drafts] fix pseudocode for TLP a… Marten Seemann
- Re: [quicwg/base-drafts] fix pseudocode for TLP a… ianswett